Re: [PATCH][RFC] -Wno-... option to suppress builtin macro redefined warnings

[Tom Tromey <tromey@redhat.com>]

>>>>> "Simon" == Simon Baldwin <simonb@google.com> writes:

Simon> Tom, any further thoughts on this?

Simon> It's certainly not hard to split built-in macros into two tiers,
Simon> those where redefinition warning can be suppressed by providing
Simon> -Wno-builtin-macro-redefined, and those where it can't.  However,
Simon> since it's all just about suppressing a warning, it may be that one
Simon> policy to cover all of them will suffice, and be simpler to manage
Simon> and maintain.


Simon> No response from Tom to date.

Sorry, I had a bit of a mail problem and missed a few things.

I think that, as a rule of thumb, we should only relax existing
pedantic checks for a good reason.  My thinking here is that, in the
past, we've had bad experiences with relaxing these rules, and so it
is best to defer it as long as we possibly can.

In this case, I can understand wanting to override date or time
macros.  However, I couldn't think of a scenario where it would make
sense to modify __LINE__.  So, I still think it would be better to
separate the cases.  I don't think the maintenance burden is a major
problem.

Perhaps some other GCC maintainer would care to weigh in.

Tom