From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29814 invoked by alias); 30 Oct 2005 04:59:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 29760 invoked by uid 22791); 30 Oct 2005 04:59:00 -0000 Received: from yosemite.airs.com (HELO yosemite.airs.com) (205.217.158.180) by sourceware.org (qpsmtpd/0.30-dev) with SMTP; Sun, 30 Oct 2005 04:59:00 +0000 Received: (qmail 29264 invoked by uid 10); 30 Oct 2005 04:58:58 -0000 Received: (qmail 9782 invoked by uid 500); 30 Oct 2005 04:58:51 -0000 To: Andrew Pinski Cc: gcc-patches@gcc.gnu.org Subject: Re: patch ping References: <200510292108.j9TL8A40024718@earth.phy.uc.edu> From: Ian Lance Taylor Date: Sun, 30 Oct 2005 04:59:00 -0000 In-Reply-To: <200510292108.j9TL8A40024718@earth.phy.uc.edu> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2005-10/txt/msg01671.txt.bz2 Andrew Pinski writes: > + /* If we have a type which is a subtype use the > + subtype instead. */ > + if (TREE_TYPE (etype)) > + etype = TREE_TYPE (etype); This makes me a bit nervous simply because I can't see anything else in fold-const.c which does anything like this. I am also somewhat troubled that I can't find any documentation on what TREE_TYPE of a INTEGER_TYPE, ENUMERAL_TYPE, or CHAR_TYPE is supposed to mean. Is that usage specific to the Ada frontend? What is the general meaning? What if you simply don't do the optimization if range_binop returns NULL? Ian