From: Tom Tromey <tromey@redhat.com>
To: "Aaron W. LaFramboise" <aaronavay62@aaronwl.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>, java-patches@gcc.gnu.org
Subject: Re: [PING] Windows patches.
Date: Tue, 26 Oct 2004 15:42:00 -0000 [thread overview]
Message-ID: <m38y9tijc5.fsf@localhost.localdomain> (raw)
In-Reply-To: <417D77C7.3060900@aaronwl.com>
>>>>> "Aaron" == Aaron W LaFramboise <aaronavay62@aaronwl.com> writes:
Aaron> 2004-10-25 Aaron W. LaFramboise <aaronavay62@aaronwl.com>
Aaron> * testsuite/lib/libjava.exp (libjava_arguments): Fix CLASSPATH
Aaron> separator handling for Windows.
This is basically ok, but could you make one little change?
Aaron> # Set the CLASSPATH environment variable
Aaron> ! verbose "CLASSPATH is .$sep$srcdir/$subdir$sep$objdir$sep$libgcj_jar"
Aaron> global env
Aaron> ! set env(CLASSPATH) ".$sep$srcdir/$subdir$sep$objdir$sep$libgcj_jar"
I suggest using join. Like:
set env(CLASSPATH) [join [list . $srscdir/$subdir $objdir $libgcj_jar] \
$sep]
verbose "CLASSPATH is $env(CLASSPATH)"
This is easier to read IMO.
Tom
next prev parent reply other threads:[~2004-10-26 15:36 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-10-23 21:58 Aaron W. LaFramboise
2004-10-24 0:33 ` Tom Tromey
2004-10-25 22:10 ` Aaron W. LaFramboise
2004-10-26 15:42 ` Tom Tromey [this message]
2004-10-25 19:19 ` DJ Delorie
2004-10-25 20:03 ` Aaron W. LaFramboise
2004-10-25 20:25 ` DJ Delorie
2004-10-25 21:12 ` E. Weddington
2004-11-05 19:10 ` Christopher Faylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m38y9tijc5.fsf@localhost.localdomain \
--to=tromey@redhat.com \
--cc=aaronavay62@aaronwl.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).