From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-131885-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 21875 invoked by alias); 26 Oct 2004 15:36:01 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 21848 invoked from network); 26 Oct 2004 15:35:59 -0000
Received: from unknown (HELO mx1.redhat.com) (66.187.233.31)
  by sourceware.org with SMTP; 26 Oct 2004 15:35:59 -0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254])
	by mx1.redhat.com (8.12.11/8.12.11) with ESMTP id i9QFZmZK022790;
	Tue, 26 Oct 2004 11:35:48 -0400
Received: from opsy.redhat.com (vpn50-9.rdu.redhat.com [172.16.50.9])
	by int-mx1.corp.redhat.com (8.11.6/8.11.6) with ESMTP id i9QFZgr04937;
	Tue, 26 Oct 2004 11:35:42 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)
	id 322F52DC086; Tue, 26 Oct 2004 09:34:50 -0600 (MDT)
To: "Aaron W. LaFramboise" <aaronavay62@aaronwl.com>
Cc: Gcc Patch List <gcc-patches@gcc.gnu.org>, java-patches@gcc.gnu.org
Subject: Re: [PING] Windows patches.
References: <417AB82F.4030405@aaronwl.com>
	<m3acudout2.fsf@localhost.localdomain> <417D77C7.3060900@aaronwl.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
X-Attribution:  Tom
Date: Tue, 26 Oct 2004 15:42:00 -0000
In-Reply-To: <417D77C7.3060900@aaronwl.com>
Message-ID: <m38y9tijc5.fsf@localhost.localdomain>
User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.3.50
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
X-SW-Source: 2004-10/txt/msg02199.txt.bz2

>>>>> "Aaron" == Aaron W LaFramboise <aaronavay62@aaronwl.com> writes:

Aaron> 2004-10-25  Aaron W. LaFramboise  <aaronavay62@aaronwl.com>
Aaron> 	* testsuite/lib/libjava.exp (libjava_arguments): Fix CLASSPATH
Aaron> 	separator handling for Windows.

This is basically ok, but could you make one little change?

Aaron>       # Set the CLASSPATH environment variable
Aaron> !     verbose "CLASSPATH is .$sep$srcdir/$subdir$sep$objdir$sep$libgcj_jar"
Aaron>       global env
Aaron> !     set env(CLASSPATH) ".$sep$srcdir/$subdir$sep$objdir$sep$libgcj_jar"
I suggest using join.  Like:

    set env(CLASSPATH) [join [list . $srscdir/$subdir $objdir $libgcj_jar] \
                             $sep]
    verbose "CLASSPATH is $env(CLASSPATH)"

This is easier to read IMO.

Tom