Patch: enable dependency tracking in libgfortran

Patch: enable dependency tracking in libgfortran

[Tom Tromey]

Andrew Pinski mentioned a libgfortran build dependency problem on irc
yesterday, and I happened to take a look.

It seems as though libgfortran disables automake's automatic
dependency tracking feature.  The comment says "just for now", and
after a bit of research I think that this was probably cut-and-pasted
from libstdc++.

Tested on x86 FC 5.

I think this obsoletes an earlier patch which adds explicit
dependencies:

    http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00594.html

Ok?

Tom

:ADDPATCH libgfortran:

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	PR libgfortran/27107:
	* aclocal.m4, configure, Makefile.in: Rebuilt.
	* configure.ac: Enable automake dependency tracking.  Update
	minimum automake version.

Index: configure.ac
===================================================================
--- configure.ac	(revision 120730)
+++ configure.ac	(working copy)
@@ -42,16 +42,15 @@
 
 # Sets up automake.  Must come after AC_CANONICAL_SYSTEM.  Each of the
 # following is magically included in AUTOMAKE_OPTIONS in each Makefile.am.
-#  1.8.2:  minimum required version
+#  1.9.6:  minimum required version
 #  no-define:  PACKAGE and VERSION will not be #define'd in config.h (a bunch
 #              of other PACKAGE_* variables will, however, and there's nothing
 #              we can do about that; they come from AC_INIT).
 #  foreign:  we don't follow the normal rules for GNU packages (no COPYING
 #            file in the top srcdir, etc, etc), so stop complaining.
-#  no-dependencies:  turns off auto dependency generation (just for now)
 #  -Wall:  turns on all automake warnings...
 #  -Wno-portability:  ...except this one, since GNU make is required.
-AM_INIT_AUTOMAKE([1.8.2 no-define foreign no-dependencies -Wall -Wno-portability])
+AM_INIT_AUTOMAKE([1.9.6 no-define foreign -Wall -Wno-portability])
 
 AM_MAINTAINER_MODE
 AM_ENABLE_MULTILIB(, ..)

Re: Patch: enable dependency tracking in libgfortran

[FX Coudert]

:REVIEWMAIL:

> It seems as though libgfortran disables automake's automatic
> dependency tracking feature.  The comment says "just for now", and
> after a bit of research I think that this was probably cut-and-pasted
> from libstdc++.

Cool! Now we get to have real dependecy tracking like grown up  
libraries :)

> I think this obsoletes an earlier patch which adds explicit
> dependencies:
>
>     http://gcc.gnu.org/ml/gcc-patches/2007-01/msg00594.html
>
> Ok?

OK. Although it doesn't completely obsolete my patch (above), because  
it's shuffling a few functions to the files they really belong to, so  
if you don't mind, I'd like to commit it first (without the explicit  
dependencies) and then commit yours. Is that OK with you? (I was on  
my way commiting my patch anyway, so it should be done real soon).

Thanks for your help,
FX

Re: Patch: enable dependency tracking in libgfortran

[Tom Tromey]

>>>>> ">" == FX Coudert <fxcoudert@gmail.com> writes:

>> OK. Although it doesn't completely obsolete my patch (above), because
>> it's shuffling a few functions to the files they really belong to, so
>> if you don't mind, I'd like to commit it first (without the explicit
>> dependencies) and then commit yours. Is that OK with you? (I was on
>> my way commiting my patch anyway, so it should be done real soon).

No problem, I'll commit after I see your patch go in.

Tom