From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7155 invoked by alias); 26 Oct 2004 01:20:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 7144 invoked from network); 26 Oct 2004 01:20:48 -0000 Received: from unknown (HELO merlin.cs.tamu.edu) (128.194.146.35) by sourceware.org with SMTP; 26 Oct 2004 01:20:48 -0000 Received: by merlin.cs.tamu.edu (Postfix, from userid 500) id 0F0D53557A; Mon, 25 Oct 2004 20:20:30 -0500 (CDT) To: Andrew Pinski Cc: Zack Weinberg , gcc-patches@gcc.gnu.org, "Joseph S. Myers" Subject: Re: New C parser [patch] References: <873c02e46k.fsf@codesourcery.com> From: Gabriel Dos Reis In-Reply-To: Organization: Texas A&M University, Department of Computer Science Date: Tue, 26 Oct 2004 01:30:00 -0000 Message-ID: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-SW-Source: 2004-10/txt/msg02146.txt.bz2 Andrew Pinski writes: | On Oct 25, 2004, at 8:03 PM, Zack Weinberg wrote: | | >> + c_parser_error (parser, | >> + "expected ':', ',', ';' or '__attribute__'"); | >> + break; | > | > These want %<%>ifying. There are several other cases - I'm not going | > to call them all out explicitly. | | But I will say that we have C++ diagnostic regressions because of | "%<%>ifying". The reason why we have this problem is because | c_parser_error takes a string but only does %s on it rather than passing | it on to the diagnostic mechanism. The calling should be c_parser_error (message) instead of c_parser_error ("%s", message); -- Gaby