From: Tom Tromey <tromey@redhat.com>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org, Richard Henderson <rth@redhat.com>
Subject: Re: [gomp] OpenMP 3.0 C parser changes
Date: Tue, 13 Nov 2007 22:42:00 -0000 [thread overview]
Message-ID: <m3ejeteur3.fsf@fleche.redhat.com> (raw)
In-Reply-To: <20071113202046.GL5451@devserv.devel.redhat.com> (Jakub Jelinek's message of "Tue\, 13 Nov 2007 15\:20\:46 -0500")
>>>>> "Jakub" == Jakub Jelinek <jakub@redhat.com> writes:
Jakub> Committed to gomp-3_0-branch.
Jakub> + error ("collapse argument needs positive constant integer expression");
Before merging back to the trunk, would you mind changing this to pass
an explicit location using %H? Perhaps the start of the expression
would be the best location. Except for the few places where it is
really difficult, I'd like to keep the C parser "%H-clean"; this is
(IMO) more maintainable and generally gives better column information.
In this particular error, maybe collapse should be quoted with %<...%>?
Jakub> + error ("schedule %<auto%> does not take "
Jakub> + "a %<chunk_size%> parameter");
... %H here too.
thanks,
Tom
next prev parent reply other threads:[~2007-11-13 21:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-13 21:54 Jakub Jelinek
2007-11-13 22:42 ` Tom Tromey [this message]
2007-11-14 21:40 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3ejeteur3.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=rth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).