From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5838 invoked by alias); 13 Nov 2007 21:14:34 -0000 Received: (qmail 5828 invoked by uid 22791); 13 Nov 2007 21:14:33 -0000 X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 13 Nov 2007 21:14:30 +0000 Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) by mx1.redhat.com (8.13.8/8.13.1) with ESMTP id lADLES3k014959 for ; Tue, 13 Nov 2007 16:14:28 -0500 Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lADLERuH014274; Tue, 13 Nov 2007 16:14:27 -0500 Received: from opsy.redhat.com (ton.yyz.redhat.com [10.15.16.15]) by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id lADLENBb026246; Tue, 13 Nov 2007 16:14:24 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id D2688378B0E; Tue, 13 Nov 2007 13:49:20 -0700 (MST) To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org, Richard Henderson Subject: Re: [gomp] OpenMP 3.0 C parser changes References: <20071113202046.GL5451@devserv.devel.redhat.com> From: Tom Tromey Reply-To: tromey@redhat.com X-Attribution: Tom Date: Tue, 13 Nov 2007 22:42:00 -0000 In-Reply-To: <20071113202046.GL5451@devserv.devel.redhat.com> (Jakub Jelinek's message of "Tue\, 13 Nov 2007 15\:20\:46 -0500") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.990 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-11/txt/msg00752.txt.bz2 >>>>> "Jakub" == Jakub Jelinek writes: Jakub> Committed to gomp-3_0-branch. Jakub> + error ("collapse argument needs positive constant integer expression"); Before merging back to the trunk, would you mind changing this to pass an explicit location using %H? Perhaps the start of the expression would be the best location. Except for the few places where it is really difficult, I'd like to keep the C parser "%H-clean"; this is (IMO) more maintainable and generally gives better column information. In this particular error, maybe collapse should be quoted with %<...%>? Jakub> + error ("schedule % does not take " Jakub> + "a % parameter"); ... %H here too. thanks, Tom