From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 95020 invoked by alias); 4 Nov 2015 14:53:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 95001 invoked by uid 89); 4 Nov 2015 14:53:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.7 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,T_RP_MATCHES_RCVD autolearn=no version=3.3.2 X-HELO: e06smtp10.uk.ibm.com Received: from e06smtp10.uk.ibm.com (HELO e06smtp10.uk.ibm.com) (195.75.94.106) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (CAMELLIA256-SHA encrypted) ESMTPS; Wed, 04 Nov 2015 14:53:50 +0000 Received: from localhost by e06smtp10.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 4 Nov 2015 14:53:47 -0000 Received: from d06dlp01.portsmouth.uk.ibm.com (9.149.20.13) by e06smtp10.uk.ibm.com (192.168.101.140) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 4 Nov 2015 14:53:45 -0000 X-IBM-Helo: d06dlp01.portsmouth.uk.ibm.com X-IBM-MailFrom: arnez@linux.vnet.ibm.com X-IBM-RcptTo: gcc-patches@gcc.gnu.org Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp01.portsmouth.uk.ibm.com (Postfix) with ESMTP id 89E8B17D8042 for ; Wed, 4 Nov 2015 14:54:00 +0000 (GMT) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id tA4ErijW8716700 for ; Wed, 4 Nov 2015 14:53:44 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id tA4EribK005119 for ; Wed, 4 Nov 2015 07:53:44 -0700 Received: from oc1027705133.ibm.com (dyn-9-152-212-195.boeblingen.de.ibm.com [9.152.212.195]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id tA4Erie4005091 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 4 Nov 2015 07:53:44 -0700 From: Andreas Arnez To: Bernd Schmidt Cc: Joseph Myers , Richard Henderson , gcc-patches@gcc.gnu.org, David Malcolm , Manuel =?utf-8?B?TMOzcGV6LUliw6HDsWV6?= , Patrick Palka , Andreas Krebbel Subject: Re: [PATCH v2] [PR debug/67192] Fix C loops' back-jump location References: <56322AAD.7080002@redhat.com> Date: Wed, 04 Nov 2015 14:53:00 -0000 In-Reply-To: (Andreas Arnez's message of "Thu, 29 Oct 2015 20:02:03 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15110414-0041-0000-0000-00000636F013 X-SW-Source: 2015-11/txt/msg00360.txt.bz2 On Thu, Oct 29 2015, Andreas Arnez wrote: > On Thu, Oct 29 2015, Bernd Schmidt wrote: >> [...] >> i.e. the breakpoint on the code inside the loop is reached before the >> while statement itself. This may be the expected behaviour with your >> patch, but I'm not sure it's really desirable for debugging. > > [...] > Maybe we could also improve the behavior of breaking on "while (1)" by > generating a NOP for it? Or by using the first loop body's token > instead? I've basically tried the latter, and it seems to work pretty well. It solves all the issues discussed in this mail thread, and I haven't found any other issues with it. I'll post the patch separately. >> I'd suggest you commit your original patch to fix the >> misleading-indent problem while we sort this out. > > I can certainly do that. But note that the original patch does not > solve the misleading-indent regression caused for f2() in the new > version of pr67192.c. Thus the PR is not really fixed by it. I've slightly changed the test case for that one, so I'll repost it as well before committing it. -- Andreas