From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27863 invoked by alias); 14 Dec 2010 08:25:23 -0000 Received: (qmail 27853 invoked by uid 22791); 14 Dec 2010 08:25:23 -0000 X-SWARE-Spam-Status: No, hits=-5.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 14 Dec 2010 08:25:18 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id oBE8P7bO022194 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Tue, 14 Dec 2010 03:25:08 -0500 Received: from adjoa.redhat.com (ovpn-113-36.phx2.redhat.com [10.3.113.36]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id oBE8P4q1012239; Tue, 14 Dec 2010 03:25:05 -0500 From: Dodji Seketeli To: Paolo Bonzini Cc: Gabriel Dos Reis , gcc-patches@gcc.gnu.org, tromey@redhat.com, joseph@codesourcery.com, lopezibanez@gmail.com Subject: Re: [PATCH 3/6] Emit macro expansion related diagnostics References: <1291979498-1604-1-git-send-email-dodji@redhat.com> <1291979498-1604-5-git-send-email-dodji@redhat.com> <4D063157.3050901@gnu.org> X-URL: http://www.redhat.com Date: Tue, 14 Dec 2010 09:23:00 -0000 In-Reply-To: (Paolo Bonzini's message of "Tue, 14 Dec 2010 09:14:16 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-12/txt/msg01074.txt.bz2 Paolo Bonzini writes: > On Tue, Dec 14, 2010 at 08:28, Gabriel Dos Reis > wrote: >> Agreed. =C2=A0But I also agree with Paolo's observation: the prefix ": note" >> has to precede the diagnostic message. =C2=A0I know there are other comp= ilers >> that do it differently, but GCC convention has been to precede diagnosti= cs >> with loci > > That was my main point, yes. I'm not sure about the verboseness of > having two lines per level of macro expansion, but I can live with > that and it was secondary in my message. OK, this is consistent with the discussion we've just had about re-using functions like inform() in another sub-thread. I'll do that then. Thanks. --=20 Dodji