From: Tom Tromey <tromey@redhat.com>
To: David Daney <ddaney@avtrex.com>
Cc: GCJ-patches <java-patches@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
andreast@gcc.gnu.org
Subject: Re: [Patch] libffi testsuite: Correct some type specifiers.
Date: Tue, 07 Aug 2007 17:04:00 -0000 [thread overview]
Message-ID: <m3fy2vuwb9.fsf@fleche.redhat.com> (raw)
In-Reply-To: <46B89D13.50708@avtrex.com> (David Daney's message of "Tue\, 07 Aug 2007 09\:25\:55 -0700")
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> Whilst hacking things up to get MIPS64 working better in libffi, I
David> came across several test cases where structure elements were declared
David> as type 'int' but the libffi type specifier identified them as uint32.
David> This patch corrects some (but probably not all) of these incongruities.
I think a patch to fix a disparity like this would qualify as obvious.
However... if the struct definition says 'int', and the test case is
says ffi_type_sint32, then that seems like a bug in itself. There's
no guarantee that int == 32 bits. Wouldn't it be more correct to use
ffi_type_sint?
Tom
next prev parent reply other threads:[~2007-08-07 17:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-07 16:27 David Daney
2007-08-07 17:04 ` Tom Tromey [this message]
2007-08-07 17:18 ` David Daney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3fy2vuwb9.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=andreast@gcc.gnu.org \
--cc=ddaney@avtrex.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=java-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).