PING: PATCH: Also check -m32 for i*86-*-linux*

PING: PATCH: Also check -m32 for i*86-*-linux*

[H.J. Lu]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

On Thu, Nov 12, 2009 at 8:11 AM, Andreas Schwab <schwab@redhat.com> wrote:
> "H.J. Lu" <hongjiu.lu@intel.com> writes:
>
>> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> index 05c0311..768975a 100644
>> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
>>           if [ string match "*64-bit*" $file_string ] {
>>               set native_cflags "-m64"
>>           }
>> -     } elseif [istarget "x86_64-*-linux*"] {
>> +     } elseif [expr [istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
>
> No need for expr, it's implicit.
>

PING without implicit expr.

Thanks.

-- 
H.J.

[-- Attachment #2: gcc-m32-3.patch --]
[-- Type: text/x-csrc, Size: 729 bytes --]

2009-11-17  H.J. Lu  <hongjiu.lu@intel.com>

	* gcc.misc-tests/linkage.exp: Also check -m32 for i*86-*-linux*.

diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
index 05c0311..768975a 100644
--- a/gcc/testsuite/gcc.misc-tests/linkage.exp
+++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
@@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
 	    if [ string match "*64-bit*" $file_string ] {
 		set native_cflags "-m64"
 	    }
-	} elseif [istarget "x86_64-*-linux*"] {
+	} elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
 	    set file_string [exec file "linkage-x.o"]
 	    if [ string match "*32-bit*" $file_string ] {
 		set native_cflags "-m32"

Re: PING: PATCH: Also check -m32 for i*86-*-linux*

[Andreas Schwab]

"H.J. Lu" <hjl.tools@gmail.com> writes:

> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
> index 05c0311..768975a 100644
> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
>  	    if [ string match "*64-bit*" $file_string ] {
>  		set native_cflags "-m64"
>  	    }
> -	} elseif [istarget "x86_64-*-linux*"] {
> +	} elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {

You want to put braces, not brackets, around the expression.

Andreas.

-- 
Andreas Schwab, schwab@redhat.com
GPG Key fingerprint = D4E8 DBE3 3813 BB5D FA84  5EC7 45C6 250E 6F00 984E
"And now for something completely different."

Re: PING: PATCH: Also check -m32 for i*86-*-linux*

[H.J. Lu]

[-- Attachment #1: Type: text/plain, Size: 818 bytes --]

On Wed, Nov 18, 2009 at 2:01 AM, Andreas Schwab <schwab@redhat.com> wrote:
> "H.J. Lu" <hjl.tools@gmail.com> writes:
>
>> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> index 05c0311..768975a 100644
>> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
>> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
>> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
>>           if [ string match "*64-bit*" $file_string ] {
>>               set native_cflags "-m64"
>>           }
>> -     } elseif [istarget "x86_64-*-linux*"] {
>> +     } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
>
> You want to put braces, not brackets, around the expression.
>

Here is the updated patch. OK for trunk?

Thanks.


-- 
H.J.

[-- Attachment #2: gcc-m32-4.patch --]
[-- Type: text/x-csrc, Size: 729 bytes --]

2009-11-17  H.J. Lu  <hongjiu.lu@intel.com>

	* gcc.misc-tests/linkage.exp: Also check -m32 for i*86-*-linux*.

diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
index 05c0311..768975a 100644
--- a/gcc/testsuite/gcc.misc-tests/linkage.exp
+++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
@@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
 	    if [ string match "*64-bit*" $file_string ] {
 		set native_cflags "-m64"
 	    }
-	} elseif [istarget "x86_64-*-linux*"] {
+	} elseif {[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]} {
 	    set file_string [exec file "linkage-x.o"]
 	    if [ string match "*32-bit*" $file_string ] {
 		set native_cflags "-m32"

Re: PING: PATCH: Also check -m32 for i*86-*-linux*

[Janis Johnson]

On Wed, 2009-11-18 at 08:11 -0800, H.J. Lu wrote:
> On Wed, Nov 18, 2009 at 2:01 AM, Andreas Schwab <schwab@redhat.com> wrote:
> > "H.J. Lu" <hjl.tools@gmail.com> writes:
> >
> >> diff --git a/gcc/testsuite/gcc.misc-tests/linkage.exp b/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> index 05c0311..768975a 100644
> >> --- a/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> +++ b/gcc/testsuite/gcc.misc-tests/linkage.exp
> >> @@ -57,7 +57,7 @@ if { [isnative] && ![is_remote host] } then {
> >>           if [ string match "*64-bit*" $file_string ] {
> >>               set native_cflags "-m64"
> >>           }
> >> -     } elseif [istarget "x86_64-*-linux*"] {
> >> +     } elseif [[istarget "i*86-*-linux*"] || [istarget "x86_64-*-linux*"]] {
> >
> > You want to put braces, not brackets, around the expression.
> >
> 
> Here is the updated patch. OK for trunk?

OK.

Janis