From: Tom Tromey <tromey@redhat.com>
To: gcc-patches List <gcc-patches@gcc.gnu.org>
Subject: Patch: 'normalization' of libmudflap Makefile.am
Date: Sat, 14 Jul 2007 21:47:00 -0000 [thread overview]
Message-ID: <m3hco6d7si.fsf@fleche.redhat.com> (raw)
I happened to notice that libmudflap's Makefile.am implemented its own
form of per-library CFLAGS. I think it is slightly better to use
Automake's built-in approach to this, since it means that dependency
tracking will work properly.
This patch implements this idea.
Tested on x86 FC6. I ran 'make check' in libmudflap's build directory
with no regressions. Ok?
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* Makefile.in: Rebuilt.
* Makefile.am (clean-local): Removed.
(pth/mf-runtime.lo, pth/mf-heuristics.lo, pth/mf-hooks1.lo,
pth/mf-hooks2.lo, pth/mf-hooks3.lo): Likewise.
(libmudflapth_la_SOURCES): List sources.
(libmudflapth_la_LIBADD): Clear.
(libmudflapth_la_CFLAGS): New variable.
Index: Makefile.am
===================================================================
--- Makefile.am (revision 126605)
+++ Makefile.am (working copy)
@@ -1,6 +1,6 @@
## Makefile for the toplevel directory of the mudflap library.
##
-## Copyright (C) 2002, 2003, 2004
+## Copyright (C) 2002, 2003, 2004, 2007
## Free Software Foundation, Inc.
##
@@ -36,28 +36,15 @@
libmudflap_la_DEPENDENCIES = $(libmudflap_la_LIBADD)
libmudflap_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version`
-clean-local:
- rm -f pth/*.o pth/*.lo
-pth/mf-runtime.lo: mf-runtime.c mf-runtime.h mf-impl.h
- $(LTCOMPILE) -DLIBMUDFLAPTH -c $(srcdir)/mf-runtime.c -o $@
-pth/mf-heuristics.lo: mf-heuristics.c mf-runtime.h mf-impl.h
- $(LTCOMPILE) -DLIBMUDFLAPTH -c $(srcdir)/mf-heuristics.c -o $@
-pth/mf-hooks1.lo: mf-hooks1.c mf-runtime.h mf-impl.h
- $(LTCOMPILE) -DLIBMUDFLAPTH -c $(srcdir)/mf-hooks1.c -o $@
-pth/mf-hooks2.lo: mf-hooks2.c mf-runtime.h mf-impl.h
- $(LTCOMPILE) -DLIBMUDFLAPTH -c $(srcdir)/mf-hooks2.c -o $@
-pth/mf-hooks3.lo: mf-hooks3.c mf-runtime.h mf-impl.h
- $(LTCOMPILE) -DLIBMUDFLAPTH -c $(srcdir)/mf-hooks3.c -o $@
-
-
-libmudflapth_la_SOURCES =
-libmudflapth_la_LIBADD = \
- pth/mf-runtime.lo \
- pth/mf-heuristics.lo \
- pth/mf-hooks1.lo \
- pth/mf-hooks2.lo \
- pth/mf-hooks3.lo
+libmudflapth_la_SOURCES = \
+ mf-runtime.c \
+ mf-heuristics.c \
+ mf-hooks1.c \
+ mf-hooks2.c \
+ mf-hooks3.c
+libmudflapth_la_CFLAGS = -DLIBMUDFLAPTH
+libmudflapth_la_LIBADD =
libmudflapth_la_DEPENDENCIES = $(libmudflapth_la_LIBADD)
libmudflapth_la_LDFLAGS = -version-info `grep -v '^\#' $(srcdir)/libtool-version`
next reply other threads:[~2007-07-14 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-14 21:47 Tom Tromey [this message]
2007-07-27 2:09 ` Ian Lance Taylor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3hco6d7si.fsf@fleche.redhat.com \
--to=tromey@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).