Patch: update -fmessage-length docs

Patch: update -fmessage-length docs

[Tom Tromey]

It turns out that -fmessage-length defaults to 0 even for g++.  This
patch updates the documentation to match.

Ok?

Tom

:ADDPATCH documentation:

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* doc/invoke.texi (Language Independent Options): Message length
	defaults to 0.

Index: doc/invoke.texi
===================================================================
--- doc/invoke.texi	(revision 123217)
+++ doc/invoke.texi	(working copy)
@@ -2394,10 +2394,8 @@
 @item -fmessage-length=@var{n}
 @opindex fmessage-length
 Try to format error messages so that they fit on lines of about @var{n}
-characters.  The default is 72 characters for @command{g++} and 0 for the rest of
-the front ends supported by GCC@.  If @var{n} is zero, then no
-line-wrapping will be done; each error message will appear on a single
-line.
+characters.  If @var{n} is zero (the default), then no line-wrapping
+will be done; each error message will appear on a single line.
 
 @opindex fdiagnostics-show-location
 @item -fdiagnostics-show-location=once

Re: Patch: update -fmessage-length docs

[Gabriel Dos Reis]

Tom Tromey <tromey@redhat.com> writes:

| It turns out that -fmessage-length defaults to 0 even for g++. 

Then, that is a bug. 
When I oiginally implemented that for C++, the intended semantics
definitely was to have it default to 72 -- but C people wanted
something different for C front end.  If it is observed that g++ has
it set to zero, then we must set it back to 72.

-- Gaby

Re: Patch: update -fmessage-length docs

[Richard Guenther]

On 29 Mar 2007 10:41:29 -0500, Gabriel Dos Reis <gdr@cs.tamu.edu> wrote:
> Tom Tromey <tromey@redhat.com> writes:
>
> | It turns out that -fmessage-length defaults to 0 even for g++.
>
> Then, that is a bug.
> When I oiginally implemented that for C++, the intended semantics
> definitely was to have it default to 72 -- but C people wanted
> something different for C front end.  If it is observed that g++ has
> it set to zero, then we must set it back to 72.

Please not, 72 is completely unusable for C++.

Richard.

Re: Patch: update -fmessage-length docs

[Tom Tromey]

>>>>> "Gaby" == Gabriel Dos Reis <gdr@cs.tamu.edu> writes:

> Tom Tromey <tromey@redhat.com> writes:
> | It turns out that -fmessage-length defaults to 0 even for g++. 

Gaby> Then, that is a bug. 
Gaby> When I oiginally implemented that for C++, the intended semantics
Gaby> definitely was to have it default to 72 -- but C people wanted
Gaby> something different for C front end.  If it is observed that g++ has
Gaby> it set to zero, then we must set it back to 72.

I don't have a preference on this, just that the docs match the
implementation.

If we change it to 72 then PR 712 should be reopened.  That is how I
noticed this :)

Tom

Re: Patch: update -fmessage-length docs

[gdr]

Quoting Richard Guenther <richard.guenther@gmail.com>:

> On 29 Mar 2007 10:41:29 -0500, Gabriel Dos Reis <gdr@cs.tamu.edu> wrote:
>> Tom Tromey <tromey@redhat.com> writes:
>>
>> | It turns out that -fmessage-length defaults to 0 even for g++.
>>
>> Then, that is a bug.
>> When I oiginally implemented that for C++, the intended semantics
>> definitely was to have it default to 72 -- but C people wanted
>> something different for C front end.  If it is observed that g++ has
>> it set to zero, then we must set it back to 72.
>
> Please not, 72 is completely unusable for C++.

how much?  80?
0 is unreadable -- that is what prompted the work in the first place.

-- Gaby

Re: Patch: update -fmessage-length docs

[Gabriel Dos Reis]

Tom Tromey <tromey@redhat.com> writes:

| >>>>> "Gaby" == Gabriel Dos Reis <gdr@cs.tamu.edu> writes:
| 
| > Tom Tromey <tromey@redhat.com> writes:
| > | It turns out that -fmessage-length defaults to 0 even for g++. 
| 
| Gaby> Then, that is a bug. 
| Gaby> When I oiginally implemented that for C++, the intended semantics
| Gaby> definitely was to have it default to 72 -- but C people wanted
| Gaby> something different for C front end.  If it is observed that g++ has
| Gaby> it set to zero, then we must set it back to 72.
| 
| I don't have a preference on this, just that the docs match the
| implementation.

I completely agree.

| If we change it to 72 then PR 712 should be reopened.  That is how I
| noticed this :)

Sure. :-)

-- Gaby

Re: Patch: update -fmessage-length docs

[Tom Tromey]

>>>>> "Gaby" == Gabriel Dos Reis <gdr@cs.tamu.edu> writes:

> | If we change it to 72 then PR 712 should be reopened.  That is how I
> | noticed this :)

Gaby> Sure. :-)

Actually, Wolfgang points out that this bug is fixed and I am
misreading the output.  Sorry about that.

Tom

Re: Patch: update -fmessage-length docs

[Tom Tromey]

>>>>> "Geoff" == Geoffrey Keating <geoffk@apple.com> writes:

>> * doc/invoke.texi (Language Independent Options): Message length
>> defaults to 0.

Geoff> In the absence of evidence that the change was intentional, I assume
Geoff> that the docs are correct and the code is wrong, so this patch is not
Geoff> OK.

Thanks.  I filed a PR: http://gcc.gnu.org/bugzilla/show_bug.cgi?id=32614

Tom