From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-274007-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 1004 invoked by alias); 29 Sep 2010 17:44:00 -0000
Received: (qmail 996 invoked by uid 22791); 29 Sep 2010 17:43:59 -0000
X-SWARE-Spam-Status: No, hits=-6.1 required=5.0	tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CP,T_RP_MATCHES_RCVD
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28)    by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 29 Sep 2010 17:43:55 +0000
Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16])	by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id o8THhrxH007612	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK);	Wed, 29 Sep 2010 13:43:53 -0400
Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199])	by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id o8THhrwi012325;	Wed, 29 Sep 2010 13:43:53 -0400
Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1])	by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id o8THhqcH028882;	Wed, 29 Sep 2010 13:43:52 -0400
Received: by opsy.redhat.com (Postfix, from userid 500)	id E5D453799D4; Wed, 29 Sep 2010 11:43:51 -0600 (MDT)
From: Tom Tromey <tromey@redhat.com>
To: Kai Tietz <ktietz70@googlemail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>, Jakub Jelinek <jakub@redhat.com>,        Andrew Pinski <pinskia@gmail.com>, Richard Henderson <rth@redhat.com>
Subject: Re: [patch preprocessor]: PR/45362 Dangling reference
References: <AANLkTimkSEcXXroTGJfF7j+_EVh7hsU-QJ6_EOYT=U3v@mail.gmail.com>	<m3aanag9nr.fsf@fleche.redhat.com>	<AANLkTin09zXb6GeSRrDQ9zArOWrDHehV1nHnJ+Pw+60j@mail.gmail.com>	<m3d3s6etbn.fsf@fleche.redhat.com> <m3r5gl8wed.fsf@fleche.redhat.com>	<AANLkTi=_tGXJAOh_GkvgRs9yuPShb-KV9MLqK7Bu8o_d@mail.gmail.com>	<m3aan94e36.fsf@fleche.redhat.com>	<AANLkTim39GRBKnKRzd0PV13oRw8BRz=L0R8-QybkCK4x@mail.gmail.com>
Date: Thu, 30 Sep 2010 06:17:00 -0000
In-Reply-To: <AANLkTim39GRBKnKRzd0PV13oRw8BRz=L0R8-QybkCK4x@mail.gmail.com>	(Kai Tietz's message of "Thu, 23 Sep 2010 15:14:06 +0200")
Message-ID: <m3iq1ojvhk.fsf@fleche.redhat.com>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2010-09/txt/msg02329.txt.bz2

>>>>> "Kai" == Kai Tietz <ktietz70@googlemail.com> writes:

Kai> Tested for x86_64-w64-mingw32 and i686-w64-mingw32. Ok for apply to 4.6?

Thanks for persevering.

Kai> +      memcpy (c->definition, defn, sizeof (uchar) * defnlen);

You don't need sizeof (uchar) here.

Kai> +	  if (c->definition)
Kai> +	    free (c->definition);

You don't need the if here.  free works fine with NULL pointers.

This is ok with those changes.  Thanks again.

Tom