From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-201028-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 3505 invoked by alias); 7 Aug 2007 21:07:02 -0000
Received: (qmail 3202 invoked by uid 22791); 7 Aug 2007 21:07:01 -0000
X-Spam-Check-By: sourceware.org
Received: from mail.codesourcery.com (HELO mail.codesourcery.com) (65.74.133.4)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Tue, 07 Aug 2007 21:06:52 +0000
Received: (qmail 1645 invoked from network); 7 Aug 2007 21:06:50 -0000
Received: from unknown (HELO localhost) (jimb@127.0.0.2)   by mail.codesourcery.com with ESMTPA; 7 Aug 2007 21:06:50 -0000
To: Mark Mitchell <mark@codesourcery.com>
Cc: Andreas Schwab <schwab@suse.de>,  gcc-patches@gcc.gnu.org, 	  libstdc++@gcc.gnu.org
Subject: Re: Make sure symbol version script is writeable
References: <m364741gqm.fsf@codesourcery.com> <jetzuonuix.fsf@sykes.suse.de> 	<m31whsp1r1.fsf@codesourcery.com> <467D7D64.6020407@codesourcery.com>
From: Jim Blandy <jimb@codesourcery.com>
Date: Tue, 07 Aug 2007 21:07:00 -0000
In-Reply-To: <467D7D64.6020407@codesourcery.com> (Mark Mitchell's message of "Sat, 23 Jun 2007 14:07:00 -0600")
Message-ID: <m3lkcngil1.fsf@codesourcery.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.50 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-08/txt/msg00462.txt.bz2


Mark Mitchell <mark@codesourcery.com> writes:
> Jim Blandy wrote:
>> Andreas Schwab <schwab@suse.de> writes:
>>> Jim Blandy <jimb@codesourcery.com> writes:
>>>
>>>> If the source tree has been made read-only, the libstdc++-v3 build
>>>> dies trying to construct src/libstdc++-symbols.ver.
>>>>
>>>> libstdc++-v3/ChangeLog:
>>>> 2007-05-07  Jim Blandy  <jimb@codesourcery.com>
>>>>
>>>> 	* libstdc++-v3/src/Makefile.am (libstdc++-symbol.ver): Make
>>>> 	sure the build tree copy of libstdc++-symbol.ver is writeable.
>>>> 	* libstdc++-v3/src/Makefile.in: Regenerated.
>>>>
>>>> Index: libstdc++-v3/src/Makefile.am
>>>> ===================================================================
>>>> --- libstdc++-v3/src/Makefile.am	(revision 124502)
>>>> +++ libstdc++-v3/src/Makefile.am	(working copy)
>>>> @@ -32,6 +32,7 @@
>>>>  libstdc++-symbols.ver:  ${glibcxx_srcdir}/$(SYMVER_FILE) \
>>>>  		$(port_specific_symbol_files)
>>>>  	cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
>>>> +	chmod +w ./libstdc++-symbol.ver
>>> You surely mean `symbols' here?
>> 
>> Yes, I certainly do.  Thanks for the close reading.  (This is what I
>> get for working with three branches at once, none of whose patches
>> apply cleanly to the others.)
>
> It doesn't look like this patch was ever applied.  With the change
> Andreas has suggested, this is OK after the lockdown.

I've committed this, revised as below:

libstdc++-v3/ChangeLog:
2007-08-07  Jim Blandy  <jimb@codesourcery.com>

	* src/Makefile.am (libstdc++-symbol.ver): Make
	sure the build tree copy of libstdc++-symbol.ver is writeable.
	* src/Makefile.in: Regenerated.

Index: libstdc++-v3/src/Makefile.am
===================================================================
--- libstdc++-v3/src/Makefile.am	(revision 127275)
+++ libstdc++-v3/src/Makefile.am	(working copy)
@@ -32,6 +32,7 @@
 libstdc++-symbols.ver:  ${glibcxx_srcdir}/$(SYMVER_FILE) \
 		$(port_specific_symbol_files)
 	cp ${glibcxx_srcdir}/$(SYMVER_FILE) ./libstdc++-symbols.ver
+	chmod +w ./libstdc++-symbols.ver
 	if test "x$(port_specific_symbol_files)" != x; then \
 	  if grep '^# Appended to version file.' \
 	       $(port_specific_symbol_files) /dev/null > /dev/null 2>&1; then \