From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15415 invoked by alias); 11 Mar 2011 14:56:17 -0000 Received: (qmail 15246 invoked by uid 22791); 11 Mar 2011 14:56:16 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Fri, 11 Mar 2011 14:56:07 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p2BEtwUq001391 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Fri, 11 Mar 2011 09:55:58 -0500 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p2BEtv8F001331; Fri, 11 Mar 2011 09:55:58 -0500 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p2BEtuAc021934; Fri, 11 Mar 2011 09:55:57 -0500 Received: by opsy.redhat.com (Postfix, from userid 500) id 72F263797CD; Fri, 11 Mar 2011 07:55:56 -0700 (MST) From: Tom Tromey To: Nathan Froyd Cc: gcc-patches@gcc.gnu.org, fortran@gcc.gnu.org, java-patches@gcc.gnu.org Subject: Re: [PATCH 07/18] generalize build_case_label to the rest of the compiler References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-8-git-send-email-froydnj@codesourcery.com> Date: Fri, 11 Mar 2011 14:56:00 -0000 In-Reply-To: <1299817406-16745-8-git-send-email-froydnj@codesourcery.com> (Nathan Froyd's message of "Thu, 10 Mar 2011 23:23:15 -0500") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-03/txt/msg00620.txt.bz2 >>>>> "Nathan" == Nathan Froyd writes: Nathan> gcc/java/ Nathan> * expr.c (expand_java_switch): Call build_case_label. Nathan> (expand_java_add_case): Likewise. The java parts are ok. FWIW, I tend to think that if a core change like this one is accepted, then updates to the front ends should be considered obvious, barring some unusual circumstance. Your update to this patch to pass a location, per the other reviews, is pre-approved. Tom