From: Ian Lance Taylor <iant@google.com>
To: Wolfgang Gellerich<gellerich@de.ibm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] middle end, s390: optimization for builtin isnan
Date: Tue, 07 Aug 2007 01:27:00 -0000 [thread overview]
Message-ID: <m3myx4p22j.fsf@localhost.localdomain> (raw)
In-Reply-To: <46B3247E.mailNXQ17I1BN@de.ibm.com>
Wolfgang Gellerich<gellerich@de.ibm.com> writes:
> This patch introduces a new target hook allowing to optimize the
> implementation of builtin function isnan on platforms like s390 where
> arithmetic operations set the condition code when the result was NaN. It
> bootstraps on Intel and s390 and does not introduce new test case failures.
It seems to me that we should handle this by treating isnan as a unary
operator which may be implemented in the MD file. E.g., implement
isnansf1 and isnandf1, with optabs. I don't see why a target hook is
the right thing here.
Ian
next prev parent reply other threads:[~2007-08-07 1:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-03 12:54 Wolfgang Gellerich
2007-08-07 1:27 ` Ian Lance Taylor [this message]
2007-08-07 14:03 ` Wolfgang Gellerich
2007-08-07 16:29 ` Ian Lance Taylor
2007-08-09 13:46 ` Wolfgang Gellerich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3myx4p22j.fsf@localhost.localdomain \
--to=iant@google.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=gellerich@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).