Fix java build on PPC (patch for libgcc-std.ver)

Fix java build on PPC (patch for libgcc-std.ver)

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 1082 bytes --]


On Linux/PPC I get the following error building GCC CVS mainline:

/usr/bin/ld: .libs/gij: hidden symbol `__unorddf2' in /usr/src/packages/BUILD/gcc-3.5.0-20040610/obj-powerpc-suse-linux/gcc/nof/libgcc.a(_unord_df.oS) is referenced by DSO
collect2: ld returned 1 exit status
make[5]: *** [gij] Error 1

The following patch fixes the problem for me and has been bootstrapped
on Linux/PPC with all multilibs.  Ok to commit?

Andreas

2004-06-10  Andreas Jaeger  <aj@suse.de>

	* libgcc-std.ver: Add __unorddf2 and __unordsf2 with version 3.5.

============================================================
Index: gcc/libgcc-std.ver
--- gcc/libgcc-std.ver	4 Sep 2003 10:47:45 -0000	1.23
+++ gcc/libgcc-std.ver	10 Jun 2004 09:26:21 -0000
@@ -211,3 +211,8 @@ GCC_3.4 {
   __paritydi2
   __parityti2
 }
+%inherit GCC_3.5 GCC_3.4
+GCC_3.5 {
+  __unorddf2
+  __unordsf2
+}
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Fix java build on PPC (patch for libgcc-std.ver)

[Richard Henderson]

On Thu, Jun 10, 2004 at 12:03:16PM +0200, Andreas Jaeger wrote:
> 	* libgcc-std.ver: Add __unorddf2 and __unordsf2 with version 3.5.

Not quite.  These symbols aren't new.  This patch ought to be
backported to all actice branches and the version symbol 
chosen appropriately.


r~

Re: Fix java build on PPC (patch for libgcc-std.ver)

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

Richard Henderson <rth@redhat.com> writes:

> On Thu, Jun 10, 2004 at 12:03:16PM +0200, Andreas Jaeger wrote:
>> 	* libgcc-std.ver: Add __unorddf2 and __unordsf2 with version 3.5.
>
> Not quite.  These symbols aren't new.  This patch ought to be
> backported to all actice branches and the version symbol 
> chosen appropriately.

We have them already in GCC 3.3, so should they be added with version
3.3.4 - or 3.3.0?

config/fp-bit.h defines __unordsf2 since version 1.1 - which means
even before 3.0 release.

So, what's the right version to choose?  3.0?  Or 3.3.4 as next
version going out?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Fix java build on PPC (patch for libgcc-std.ver)

[Richard Henderson]

On Thu, Jun 10, 2004 at 07:44:20PM +0200, Andreas Jaeger wrote:
> So, what's the right version to choose?  3.0?  Or 3.3.4 as next
> version going out?

3.3.4, I guess.


r~

Re: Fix java build on PPC (patch for libgcc-std.ver)

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 1563 bytes --]

Richard Henderson <rth@redhat.com> writes:

> On Thu, Jun 10, 2004 at 07:44:20PM +0200, Andreas Jaeger wrote:
>> So, what's the right version to choose?  3.0?  Or 3.3.4 as next
>> version going out?
>
> 3.3.4, I guess.

So, is the appended patch fine for all branches (3.3, 3.4, mainline)?
I'll do a bootstrap on mainline on Linux/PPC, Linux/PPC64, Linux/ia64,
Linux/i386, Linux/AMD64 now..

Andreas

2004-06-11  Andreas Jaeger  <aj@suse.de>

	* libgcc-std.ver: Add __unorddf2 and __unordsf2 with version 3.3.4.
	* libgcc-darwin.ver: Likewise.

============================================================
Index: gcc/libgcc-darwin.ver
--- gcc/libgcc-darwin.ver	19 Nov 2003 05:17:14 -0000	2.1
+++ gcc/libgcc-darwin.ver	11 Jun 2004 06:49:31 -0000
@@ -194,6 +194,11 @@ GCC_3.3.1 {
 %inherit GCC_3.3.2 GCC_3.3.1
 GCC_3.3.2 {
 }
+%inherit GCC_3.3.4 GCC_3.3.2
+GCC_3.3.4 {
+  __unorddf2
+  __unordsf2
+}
 
 %inherit GCC_3.4 GCC_3.3
 GCC_3.4 {
============================================================
Index: gcc/libgcc-std.ver
--- gcc/libgcc-std.ver	4 Sep 2003 10:47:45 -0000	1.23
+++ gcc/libgcc-std.ver	11 Jun 2004 06:49:32 -0000
@@ -194,6 +194,11 @@ GCC_3.3.1 {
 %inherit GCC_3.3.2 GCC_3.3.1
 GCC_3.3.2 {
 }
+%inherit GCC_3.3.4 GCC_3.3.2
+GCC_3.3.4 {
+  __unorddf2
+  __unordsf2
+}
 
 %inherit GCC_3.4 GCC_3.3.2
 GCC_3.4 {

-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]

Re: Fix java build on PPC (patch for libgcc-std.ver)

[Richard Henderson]

On Fri, Jun 11, 2004 at 08:51:20AM +0200, Andreas Jaeger wrote:
> 	* libgcc-std.ver: Add __unorddf2 and __unordsf2 with version 3.3.4.
> 	* libgcc-darwin.ver: Likewise.

Nearly.

> +%inherit GCC_3.3.4 GCC_3.3.2
> +GCC_3.3.4 {
> +  __unorddf2
> +  __unordsf2
> +}
>  
>  %inherit GCC_3.4 GCC_3.3

Uli says it's ok to change the inherit line for 3.4 to the new 3.3.4 version.


r~

Re: Fix java build on PPC (patch for libgcc-std.ver)

[Andreas Jaeger]

[-- Attachment #1: Type: text/plain, Size: 826 bytes --]

Richard Henderson <rth@redhat.com> writes:

> On Fri, Jun 11, 2004 at 08:51:20AM +0200, Andreas Jaeger wrote:
>> 	* libgcc-std.ver: Add __unorddf2 and __unordsf2 with version 3.3.4.
>> 	* libgcc-darwin.ver: Likewise.
>
> Nearly.
>
>> +%inherit GCC_3.3.4 GCC_3.3.2
>> +GCC_3.3.4 {
>> +  __unorddf2
>> +  __unordsf2
>> +}
>>  
>>  %inherit GCC_3.4 GCC_3.3
>
> Uli says it's ok to change the inherit line for 3.4 to the new 3.3.4 version.

Thanks, I'll make that change now.  I take this as an approval for all
branches - but I'm not sure about 3.3 commit, so: Can I commit this
also to the 3.3 branch, Gaby?

Andreas
-- 
 Andreas Jaeger, aj@suse.de, http://www.suse.de/~aj
  SUSE Linux AG, Maxfeldstr. 5, 90409 Nürnberg, Germany
   GPG fingerprint = 93A3 365E CE47 B889 DF7F  FED1 389A 563C C272 A126

[-- Attachment #2: Type: application/pgp-signature, Size: 188 bytes --]