public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@redhat.com>
To: Jason Merrill <jason@redhat.com>
Cc: gcc-patches@gcc.gnu.org, tromey@redhat.com,
	gdr@integrable-solutions.net,        joseph@codesourcery.com,
	burnus@net-b.de, charlet@act-europe.fr,        bonzini@gnu.org
Subject: Re: [PATCH 3/7] Emit macro expansion related diagnostics
Date: Mon, 17 Oct 2011 09:57:00 -0000	[thread overview]
Message-ID: <m3obxgxbk1.fsf@redhat.com> (raw)
In-Reply-To: <4E98A636.9090401@redhat.com> (Jason Merrill's message of "Fri,	14 Oct 2011 17:14:30 -0400")

Jason Merrill <jason@redhat.com> writes:

> On 10/13/2011 01:12 PM, Dodji Seketeli wrote:
>> +  while (true)
>> +    {
>> +      if (!linemap_macro_expansion_map_p (map0)
>> +         || !linemap_macro_expansion_map_p (map1)
>> +         || map0 == map1)
>> +       break;
>
> I'd put the test in the condition, but if you find it clearer this
> way, I guess that's fine.

I've done the change.

Let's go ahead and check all this in.

Thanks.

I'll send the final set of patches I'll commit, to ease future
references.  It will not contain the patch which subject was "Kill
pedantic warnings on system headers macros" as I'll need to change the C
(and probably the C++) FE to make each declspec have its own location
first.

-- 
		Dodji

  reply	other threads:[~2011-10-17  8:33 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-04 21:07 Jason Merrill
2011-10-04 21:31 ` Dodji Seketeli
2011-10-11  9:09 ` Dodji Seketeli
2011-10-11 15:15   ` Jason Merrill
2011-10-12 17:44     ` Gabriel Dos Reis
2011-10-13 17:32     ` Dodji Seketeli
2011-10-14 22:21       ` Jason Merrill
2011-10-17  9:57         ` Dodji Seketeli [this message]
  -- strict thread matches above, loose matches on Subject: below --
2010-12-10 11:27 [PATCH 0/6] Tracking locations of tokens resulting from macro expansion Dodji Seketeli
2011-07-16 14:38 ` [PATCH 0/7] " Dodji Seketeli
     [not found]   ` <cover.1310824120.git.dodji@redhat.com>
2011-07-16 14:38     ` [PATCH 3/7] Emit macro expansion related diagnostics Dodji Seketeli
2011-08-04 15:32       ` Dodji Seketeli
2011-09-12 21:54         ` Jason Merrill
2011-09-16  8:19           ` Dodji Seketeli
2011-09-17 21:27             ` Jason Merrill
2011-09-19 14:37               ` Dodji Seketeli
2011-09-19 19:47                 ` Jason Merrill
2011-09-19 21:27                   ` Jason Merrill
2011-09-20  8:47                     ` Dodji Seketeli
2011-09-20 14:12                       ` Jason Merrill
2011-09-20 14:12                         ` Dodji Seketeli
2011-09-21  2:51                           ` Jason Merrill
2011-09-21 19:09                             ` Dodji Seketeli
2011-09-22 15:32                               ` Jason Merrill
2011-09-26 21:11                                 ` Dodji Seketeli
2011-09-26 22:30                                   ` Jason Merrill
2011-09-27 18:43                                     ` Dodji Seketeli
2011-09-29  7:05                                       ` Jason Merrill
2011-09-29 19:20                                         ` Dodji Seketeli
2011-09-29 21:25                                           ` Jason Merrill
2011-09-29 23:33                                             ` Dodji Seketeli
2011-09-30 15:56                                               ` Jason Merrill
2011-09-30 21:04                                                 ` Jason Merrill
2011-10-03 22:50                                                   ` Dodji Seketeli
2011-10-04 19:59                                                     ` Jason Merrill
2011-10-04 20:35                                                       ` Dodji Seketeli
2011-10-03 20:09                                                 ` Dodji Seketeli
2011-10-04 20:03                                                   ` Jason Merrill
2011-10-04 20:28                                                     ` Dodji Seketeli
2011-09-20  0:08                   ` Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3obxgxbk1.fsf@redhat.com \
    --to=dodji@redhat.com \
    --cc=bonzini@gnu.org \
    --cc=burnus@net-b.de \
    --cc=charlet@act-europe.fr \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=gdr@integrable-solutions.net \
    --cc=jason@redhat.com \
    --cc=joseph@codesourcery.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).