From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3570 invoked by alias); 12 May 2011 17:52:06 -0000 Received: (qmail 3557 invoked by uid 22791); 12 May 2011 17:52:04 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 12 May 2011 17:51:44 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4CHpiIa027371 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Thu, 12 May 2011 13:51:44 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id p4CHpgrA016159; Thu, 12 May 2011 13:51:42 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4CHpe4F021111; Thu, 12 May 2011 13:51:40 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 0844A37848C; Thu, 12 May 2011 11:51:39 -0600 (MDT) From: Tom Tromey To: Jakub Jelinek Cc: Richard Henderson , Jason Merrill , Cary Coutant , gcc-patches@gcc.gnu.org, Roland McGrath , Jan Kratochvil , Mark Wielaard Subject: Re: [RFC PATCH] Typed DWARF stack References: <20110325113237.GY18914@tyan-ft48-01.lab.bos.redhat.com> <20110504183353.GI17079@tyan-ft48-01.lab.bos.redhat.com> Date: Thu, 12 May 2011 21:16:00 -0000 In-Reply-To: (Tom Tromey's message of "Wed, 04 May 2011 13:53:29 -0600") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg00922.txt.bz2 Just for the record... Tom> What my patch does now is that it generally uses a signed integer type Tom> of the appropriate width for "legacy" DWARF values. Then, for mod, if Tom> the value's type is this special type, it converts it to an Tom> identically-sized unsigned type, and converts back after the operation. Tom> For DW_OP_shr, I always convert the LHS to an appropriately-sized Tom> unsigned type first. I have since changed this. For explicitly-typed values, I tried DW_OP_shr and DW_OP_shra identically. The type encodes the desired operation. For "old-style" untyped values, DW_OP_shr converts to unsigned. I thought this approach was most consistent with the rest of the specification. Tom