Re: [PATCH][RFC] -Wno-... option to suppress builtin macro redefined warnings

[Tom Tromey <tromey@redhat.com>]

>>>>> "Manuel" == Manuel López-Ibáñez <lopezibanez@gmail.com> writes:

Manuel> 2008/8/8 Tom Tromey <tromey@redhat.com>:
>>>>>>> "Simon" == Simon Baldwin <simonb@google.com> writes:

Simon> This patch adds a warning suppression flag,
Simon> -Wno-builtin-macro-redefined, to silence gcc warnings where
Simon> builtin macros such as __TIME__ are undefined or redefined,
Simon> either on the command line or by directives.

>> This seems like a reasonable thing to want to do.

Manuel> Do we need an option? Why not allow redefinition of (some) builtin
Manuel> macros by default?

For standard predefined macros (at least __DATE__ and __TIME__), the
standard prohibits redefinition.  So, I think it makes sense to
require users to ask for this.

We could do something different for GNU C, I guess.  By default I'd
prefer not to add a case here, but I don't feel very strongly about
it.  I do think it makes sense to let users use this new feature
without committing to GNU C, though.  So, at least IMO, the option is
needed regardless.

Tom