From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3764 invoked by alias); 25 May 2011 20:11:58 -0000 Received: (qmail 3747 invoked by uid 22791); 25 May 2011 20:11:53 -0000 X-SWARE-Spam-Status: No, hits=-6.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 May 2011 20:11:33 +0000 Received: from int-mx01.intmail.prod.int.phx2.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id p4PKBRFs019164 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK); Wed, 25 May 2011 16:11:27 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx01.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id p4PKBQkg008019; Wed, 25 May 2011 16:11:26 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id p4PKBPO2027404; Wed, 25 May 2011 16:11:26 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2FC0B3781A6; Wed, 25 May 2011 14:11:24 -0600 (MDT) From: Tom Tromey To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org Subject: Re: Create common hooks structure shared between driver and cc1 References: Date: Wed, 25 May 2011 21:40:00 -0000 In-Reply-To: (Joseph S. Myers's message of "Wed, 25 May 2011 19:21:58 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-05/txt/msg01931.txt.bz2 >>>>> "Joseph" == Joseph S Myers writes: Joseph> dependencies. For the latter, I looked again at Tom's reverted patch Joseph> from March 2008 to use automatic dependency generation. Although Joseph> there is now a fixed GNU make release (since last July), and although Joseph> I'd like to see automatic dependency generation go in (I hope Paolo Joseph> may follow up on it as per Joseph> ), actually Joseph> getting it working looks like a potential rathole and I couldn't Joseph> figure out from the 2008 thread what the makefile feature was that Joseph> caused problems with a GNU make bug and whether it would be possible Joseph> to disable use of that feature (instead having stupid dependencies of Joseph> all objects on all headers) when using older versions of make (which Joseph> would I think be desirable, to avoid forcing everyone to upgrade make Joseph> immediately). I believe the bugs referenced here were the problem: http://gcc.gnu.org/ml/gcc-patches/2008-03/msg01680.html Both these bugs use .INTERMEDIATE in their test cases, but it isn't clear to me that this is a sufficient condition. My understanding is that the bug has been fixed in GNU make 3.82. As you point out, this has been out nearly a year; I think upgrading is not an extreme hardship. If you wanted to experiment with Makefile workarounds, I think the simplest way would be to check out the revision before the patch was reverted. Trying to apply the patch to current trunk is indeed a rathole. Tom