public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: ebotcazou@adacore.com (Eric Botcazou), gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Fix ICE in simplify_immed_subreg on SPU
Date: Sun, 15 Jun 2008 22:25:00 -0000	[thread overview]
Message-ID: <m3prqimj70.fsf@google.com> (raw)
In-Reply-To: <200806151727.m5FHRZDv021734@d12av02.megacenter.de.ibm.com> (Ulrich Weigand's message of "Sun\, 15 Jun 2008 19\:27\:35 +0200 \(CEST\)")

"Ulrich Weigand" <uweigand@de.ibm.com> writes:

> Eric Botcazou wrote:
>
>> > It seems to me that having an address constant like the above appear
>> > within a CONST_VECTOR should be OK -- it just cannot be simplified
>> > by simplify_immed_subreg so that function should return NULL_RTX.
>> 
>> No, we already ran into this on x86, CONST_VECTOR should only contain the 
>> aforementioned 3 kinds of constants.
>
> Why is this?  It seems constructing the vector in the constant pool
> and loading it from there is the most efficient way to load this
> particular vector on the SPU -- but I don't see how to express this
> in a different manner without using a CONST_VECTOR ...

I think I'm with Ulrich here.  A CONST_VECTOR containing a CONST seems
reasonable to me.  Eric, can you clarify what you see as the problem?

Ian

  parent reply	other threads:[~2008-06-15 22:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-15 15:53 Ulrich Weigand
2008-06-15 17:27 ` Eric Botcazou
2008-06-15 17:43   ` Ulrich Weigand
2008-06-15 22:24     ` Eric Botcazou
2008-06-15 22:25     ` Ian Lance Taylor [this message]
2008-06-15 22:45       ` Eric Botcazou
2008-06-15 22:49         ` Andrew Pinski
2008-06-26 22:15         ` [PATCH, v2] " Ulrich Weigand
2008-06-26 23:14           ` trevor_smigiel
2008-06-27  7:05           ` Eric Botcazou
2008-06-28 17:53             ` Ulrich Weigand
2008-06-30  8:27               ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3prqimj70.fsf@google.com \
    --to=iant@google.com \
    --cc=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=uweigand@de.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).