public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Richard Sandiford <richard@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [tree->rtl] Fix execute/20041124-1.c for SH PIC
Date: Sat, 11 Aug 2007 00:34:00 -0000	[thread overview]
Message-ID: <m3r6ma7vvt.fsf@localhost.localdomain> (raw)
In-Reply-To: <87abszb5sl.fsf@firetop.home>

Richard Sandiford <richard@codesourcery.com> writes:

> -	  if (REG_P (valreg)
> -	      && HARD_REGISTER_P (valreg)
> -	      && CLASS_LIKELY_SPILLED_P (REGNO_REG_CLASS (REGNO (valreg)))
> -	      && !(REG_P (target) && !HARD_REGISTER_P (target)))
> -	    valreg = copy_to_reg (valreg);
> +	  valreg = avoid_likely_spilled_reg (valreg);

You've dropped the test of whether TARGET is a hard register.  Why?
It's probably OK to drop that when you have a complex mode, but you've
dropped it in all cases.

Ian

  reply	other threads:[~2007-08-11  0:34 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 18:31 Richard Sandiford
2007-08-11  0:34 ` Ian Lance Taylor [this message]
2007-08-11 13:09   ` Richard Sandiford
2007-08-11 15:49     ` Ian Lance Taylor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3r6ma7vvt.fsf@localhost.localdomain \
    --to=iant@google.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard@codesourcery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).