From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29272 invoked by alias); 11 Aug 2007 00:34:37 -0000 Received: (qmail 29143 invoked by uid 22791); 11 Aug 2007 00:34:36 -0000 X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.33.17) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 11 Aug 2007 00:34:32 +0000 Received: from zps77.corp.google.com (zps77.corp.google.com [172.25.146.77]) by smtp-out.google.com with ESMTP id l7B0YHJV023222; Sat, 11 Aug 2007 01:34:18 +0100 Received: from localhost.localdomain.google.com (dhcp-172-18-223-110.corp.google.com [172.18.223.110]) (authenticated bits=0) by zps77.corp.google.com with ESMTP id l7B0YEaT014351 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NOT); Fri, 10 Aug 2007 17:34:14 -0700 To: Richard Sandiford Cc: gcc-patches@gcc.gnu.org Subject: Re: [tree->rtl] Fix execute/20041124-1.c for SH PIC References: <87abszb5sl.fsf@firetop.home> From: Ian Lance Taylor Date: Sat, 11 Aug 2007 00:34:00 -0000 In-Reply-To: <87abszb5sl.fsf@firetop.home> Message-ID: User-Agent: Gnus/5.09 (Gnus v5.9.0) Emacs/21.4 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2007-08/txt/msg00722.txt.bz2 Richard Sandiford writes: > - if (REG_P (valreg) > - && HARD_REGISTER_P (valreg) > - && CLASS_LIKELY_SPILLED_P (REGNO_REG_CLASS (REGNO (valreg))) > - && !(REG_P (target) && !HARD_REGISTER_P (target))) > - valreg = copy_to_reg (valreg); > + valreg = avoid_likely_spilled_reg (valreg); You've dropped the test of whether TARGET is a hard register. Why? It's probably OK to drop that when you have a complex mode, but you've dropped it in all cases. Ian