* [PATCH 09/22] Enable building libbacktrace with Intel CET
@ 2017-10-12 20:03 Tsimbalist, Igor V
2017-10-12 23:59 ` Ian Lance Taylor
0 siblings, 1 reply; 7+ messages in thread
From: Tsimbalist, Igor V @ 2017-10-12 20:03 UTC (permalink / raw)
To: gcc-patches; +Cc: Jeff Law, ian, Tsimbalist, Igor V
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
Enable building libbacktrace with CET options.
libbacktrace/
* configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
* aclocal.m4: Regenerate.
* Makefile.in: Likewise.
* configure: Likewise.
Igor
[-- Attachment #2: 0009-Enable-building-libbacktrace-with-Intel-CET.PATCH --]
[-- Type: application/octet-stream, Size: 5263 bytes --]
From b096203712abda18f8bfc5567c1842671a3da207 Mon Sep 17 00:00:00 2001
From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Date: Thu, 10 Aug 2017 12:14:11 +0300
Subject: [PATCH 09/22] Enable building libbacktrace with Intel CET
libbacktrace/
* configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
* aclocal.m4: Regenerate.
* Makefile.in: Likewise.
* configure: Likewise.
---
libbacktrace/Makefile.in | 4 ++-
libbacktrace/aclocal.m4 | 2 ++
libbacktrace/configure | 78 +++++++++++++++++++++++++++++++++++++++++++++--
libbacktrace/configure.ac | 6 ++++
4 files changed, 87 insertions(+), 3 deletions(-)
---
libbacktrace/Makefile.in | 4 ++-
libbacktrace/aclocal.m4 | 2 ++
libbacktrace/configure | 78 +++++++++++++++++++++++++++++++++++++++++++++--
libbacktrace/configure.ac | 6 ++++
4 files changed, 87 insertions(+), 3 deletions(-)
diff --git a/libbacktrace/Makefile.in b/libbacktrace/Makefile.in
index 2d8c212..9566c24 100644
--- a/libbacktrace/Makefile.in
+++ b/libbacktrace/Makefile.in
@@ -92,7 +92,9 @@ DIST_COMMON = README ChangeLog $(srcdir)/Makefile.in \
$(am__configure_deps) $(srcdir)/config.h.in \
$(srcdir)/../mkinstalldirs $(srcdir)/backtrace-supported.h.in
ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
-am__aclocal_m4_deps = $(top_srcdir)/../config/lead-dot.m4 \
+am__aclocal_m4_deps = $(top_srcdir)/../config/cet.m4 \
+ $(top_srcdir)/../config/enable.m4 \
+ $(top_srcdir)/../config/lead-dot.m4 \
$(top_srcdir)/../config/multi.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../config/stdint.m4 \
diff --git a/libbacktrace/aclocal.m4 b/libbacktrace/aclocal.m4
index 8e84ddd..7a6ea55 100644
--- a/libbacktrace/aclocal.m4
+++ b/libbacktrace/aclocal.m4
@@ -670,6 +670,8 @@ AC_SUBST([am__tar])
AC_SUBST([am__untar])
]) # _AM_PROG_TAR
+m4_include([../config/cet.m4])
+m4_include([../config/enable.m4])
m4_include([../config/lead-dot.m4])
m4_include([../config/multi.m4])
m4_include([../config/override.m4])
diff --git a/libbacktrace/configure b/libbacktrace/configure
index 3576734..73cb077 100755
--- a/libbacktrace/configure
+++ b/libbacktrace/configure
@@ -735,6 +735,7 @@ enable_fast_install
with_gnu_ld
enable_libtool_lock
enable_largefile
+enable_cet
with_system_libunwind
enable_host_shared
'
@@ -1376,6 +1377,8 @@ Optional Features:
optimize for fast installation [default=yes]
--disable-libtool-lock avoid locking (might break parallel builds)
--disable-largefile omit support for large files
+ --enable-cet enable Intel CET in target libraries
+ [default=default]
--enable-host-shared build host code as shared libraries
Optional Packages:
@@ -11136,7 +11139,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 11139 "configure"
+#line 11142 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -11242,7 +11245,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 11245 "configure"
+#line 11248 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -11774,6 +11777,77 @@ $as_echo "$libbacktrace_cv_c_random_seed_string" >&6; }
fi
fi
+if test -n "${with_target_subdir}"; then
+ # Add CET specific flags is Intel CET is enabled.
+ # Check whether --enable-cet was given.
+if test "${enable_cet+set}" = set; then :
+ enableval=$enable_cet;
+ case "$enableval" in
+ yes|no|default) ;;
+ *) as_fn_error "Unknown argument to enable/disable cet" "$LINENO" 5 ;;
+ esac
+
+else
+ enable_cet=default
+fi
+
+
+case "$target" in
+ i3456786-*-linux* | x86_64-*-linux*)
+ case "$enable_cet" in
+ default)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+ enable_cet=yes
+else
+ enable_cet=no
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ yes)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+
+else
+ as_fn_error "assembler with CET support is required for --enable-cet" "$LINENO" 5
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ esac
+ ;;
+ *)
+ enable_cet=no
+ ;;
+esac
+if test x$enable_cet = xyes; then
+ CET_FLAGS="-fcf-protection -mcet -include cet.h"
+fi
+
+ EXTRA_FLAGS="$EXTRA_FLAGS $CET_FLAGS"
+fi
+
ac_ext=c
ac_cpp='$CPP $CPPFLAGS'
diff --git a/libbacktrace/configure.ac b/libbacktrace/configure.ac
index e644c7d..bd39243 100644
--- a/libbacktrace/configure.ac
+++ b/libbacktrace/configure.ac
@@ -130,6 +130,12 @@ else
EXTRA_FLAGS="$EXTRA_FLAGS -frandom-seed=\$@"
fi
fi
+
+if test -n "${with_target_subdir}"; then
+ # Add CET specific flags is Intel CET is enabled.
+ GCC_CET_FLAGS(CET_FLAGS)
+ EXTRA_FLAGS="$EXTRA_FLAGS $CET_FLAGS"
+fi
AC_SUBST(EXTRA_FLAGS)
ACX_PROG_CC_WARNING_OPTS([-W -Wall -Wwrite-strings -Wstrict-prototypes \
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 09/22] Enable building libbacktrace with Intel CET
2017-10-12 20:03 [PATCH 09/22] Enable building libbacktrace with Intel CET Tsimbalist, Igor V
@ 2017-10-12 23:59 ` Ian Lance Taylor
2017-10-13 14:59 ` Jeff Law
2017-10-13 15:18 ` Tsimbalist, Igor V
0 siblings, 2 replies; 7+ messages in thread
From: Ian Lance Taylor @ 2017-10-12 23:59 UTC (permalink / raw)
To: Tsimbalist, Igor V; +Cc: gcc-patches, Jeff Law
"Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> writes:
> Enable building libbacktrace with CET options.
>
> libbacktrace/
> * configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
> * aclocal.m4: Regenerate.
> * Makefile.in: Likewise.
> * configure: Likewise.
> +if test x$enable_cet = xyes; then
> + CET_FLAGS="-fcf-protection -mcet -include cet.h"
> +fi
Is this really right? Why the -include option? CET protection sounds
like it should work for any language, but -include is C-specific and
doesn't seem to have anything to do with code generation.
Of course, for libbacktrace, that is a generated file. The patch to
libbacktrace/configure.ac is fine if the general approach is approved.
Ian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 09/22] Enable building libbacktrace with Intel CET
2017-10-12 23:59 ` Ian Lance Taylor
@ 2017-10-13 14:59 ` Jeff Law
2017-10-13 15:18 ` Tsimbalist, Igor V
1 sibling, 0 replies; 7+ messages in thread
From: Jeff Law @ 2017-10-13 14:59 UTC (permalink / raw)
To: Ian Lance Taylor, Tsimbalist, Igor V; +Cc: gcc-patches
On 10/12/2017 05:58 PM, Ian Lance Taylor wrote:
> "Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> writes:
>
>> Enable building libbacktrace with CET options.
>>
>> libbacktrace/
>> * configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
>> * aclocal.m4: Regenerate.
>> * Makefile.in: Likewise.
>> * configure: Likewise.
>
>> +if test x$enable_cet = xyes; then
>> + CET_FLAGS="-fcf-protection -mcet -include cet.h"
>> +fi
>
> Is this really right? Why the -include option? CET protection sounds
> like it should work for any language, but -include is C-specific and
> doesn't seem to have anything to do with code generation.
Agreed. And more generally it seems that we want to be able to just use
the -f/-m options to enable/disable CET checking. If we're having to
include additional files to get CET support, then we need to go back and
rethink things somewhere.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 09/22] Enable building libbacktrace with Intel CET
2017-10-12 23:59 ` Ian Lance Taylor
2017-10-13 14:59 ` Jeff Law
@ 2017-10-13 15:18 ` Tsimbalist, Igor V
2017-10-13 16:56 ` Ian Lance Taylor
1 sibling, 1 reply; 7+ messages in thread
From: Tsimbalist, Igor V @ 2017-10-13 15:18 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: gcc-patches, Jeff Law, Tsimbalist, Igor V
> -----Original Message-----
> From: Ian Lance Taylor [mailto:ian@airs.com]
> Sent: Friday, October 13, 2017 1:59 AM
> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
> Cc: gcc-patches@gcc.gnu.org; Jeff Law <law@redhat.com>
> Subject: Re: [PATCH 09/22] Enable building libbacktrace with Intel CET
>
> "Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> writes:
>
> > Enable building libbacktrace with CET options.
> >
> > libbacktrace/
> > * configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
> > * aclocal.m4: Regenerate.
> > * Makefile.in: Likewise.
> > * configure: Likewise.
>
> > +if test x$enable_cet = xyes; then
> > + CET_FLAGS="-fcf-protection -mcet -include cet.h"
> > +fi
>
> Is this really right? Why the -include option? CET protection sounds like it
> should work for any language, but -include is C-specific and doesn't seem to
> have anything to do with code generation.
This file is included to simplify building a library that might have assembler files.
This is an auxiliary file to automate creation of a special section in an output object
file. Without it every assembler file has to be modified by hand to include a special
section. This "-include cet.h " option is specified at a high level to not bother if a
library has or does not have assembler files. The option either has no effect if
all source files are C/C++ or used only for assembler file processing. The file itself
has an assembler code. The same code is generated by the compiler for each
input C/C++/etc. files.
In real life a user who is going to write an assemble code and have it CET compatible
has to add a special section to mark the object file as CET compatible.
Igor
> Of course, for libbacktrace, that is a generated file. The patch to
> libbacktrace/configure.ac is fine if the general approach is approved.
>
> Ian
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 09/22] Enable building libbacktrace with Intel CET
2017-10-13 15:18 ` Tsimbalist, Igor V
@ 2017-10-13 16:56 ` Ian Lance Taylor
2017-10-31 11:49 ` Tsimbalist, Igor V
0 siblings, 1 reply; 7+ messages in thread
From: Ian Lance Taylor @ 2017-10-13 16:56 UTC (permalink / raw)
To: Tsimbalist, Igor V; +Cc: gcc-patches, Jeff Law
"Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> writes:
>
> This file is included to simplify building a library that might have
> assembler files.
> This is an auxiliary file to automate creation of a special section in
> an output object
> file. Without it every assembler file has to be modified by hand to
> include a special
> section. This "-include cet.h " option is specified at a high level to
> not bother if a
> library has or does not have assembler files. The option either has no effect if
> all source files are C/C++ or used only for assembler file
> processing. The file itself
> has an assembler code. The same code is generated by the compiler for each
> input C/C++/etc. files.
>
> In real life a user who is going to write an assemble code and have it
> CET compatible
> has to add a special section to mark the object file as CET compatible.
I guess I don't understand how you can assume that general assembly code
is CET compatible. And if you know it is CET compatible then adding the
section seems simple enough; people already do it routinely for
.note.GNU-stack.
In any case a -include file such as you describe does not belong in a
general FLAGS variable, it belongs in CPPFLAGS or, ideally, ASPPFLAGS if
there were such a Make variable.
Ian
^ permalink raw reply [flat|nested] 7+ messages in thread
* RE: [PATCH 09/22] Enable building libbacktrace with Intel CET
2017-10-13 16:56 ` Ian Lance Taylor
@ 2017-10-31 11:49 ` Tsimbalist, Igor V
2017-11-08 17:30 ` Jeff Law
0 siblings, 1 reply; 7+ messages in thread
From: Tsimbalist, Igor V @ 2017-10-31 11:49 UTC (permalink / raw)
To: Ian Lance Taylor; +Cc: gcc-patches, Jeff Law, Tsimbalist, Igor V
[-- Attachment #1: Type: text/plain, Size: 1899 bytes --]
The revised patch is attached. The differences are in what options are defined and propagated to Makefile for CET enabling. -iclude option is dropped, each needed asm file is processed separately.
Igor
> -----Original Message-----
> From: Ian Lance Taylor [mailto:ian@airs.com]
> Sent: Friday, October 13, 2017 6:45 PM
> To: Tsimbalist, Igor V <igor.v.tsimbalist@intel.com>
> Cc: gcc-patches@gcc.gnu.org; Jeff Law <law@redhat.com>
> Subject: Re: [PATCH 09/22] Enable building libbacktrace with Intel CET
>
> "Tsimbalist, Igor V" <igor.v.tsimbalist@intel.com> writes:
>
> >
> > This file is included to simplify building a library that might have
> > assembler files.
> > This is an auxiliary file to automate creation of a special section in
> > an output object
> > file. Without it every assembler file has to be modified by hand to
> > include a special
> > section. This "-include cet.h " option is specified at a high level to
> > not bother if a
> > library has or does not have assembler files. The option either has no effect
> if
> > all source files are C/C++ or used only for assembler file
> > processing. The file itself
> > has an assembler code. The same code is generated by the compiler for
> each
> > input C/C++/etc. files.
> >
> > In real life a user who is going to write an assemble code and have it
> > CET compatible
> > has to add a special section to mark the object file as CET compatible.
>
> I guess I don't understand how you can assume that general assembly code
> is CET compatible. And if you know it is CET compatible then adding the
> section seems simple enough; people already do it routinely for
> .note.GNU-stack.
>
> In any case a -include file such as you describe does not belong in a
> general FLAGS variable, it belongs in CPPFLAGS or, ideally, ASPPFLAGS if
> there were such a Make variable.
>
> Ian
[-- Attachment #2: 0009-Enable-building-libbacktrace-with-Intel-CET.PATCH --]
[-- Type: application/octet-stream, Size: 5069 bytes --]
From d41da8a9f48e5b98d5e8e0e43805734c822e0caa Mon Sep 17 00:00:00 2001
From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
Date: Fri, 27 Oct 2017 15:56:39 +0300
Subject: [PATCH 09/21] Enable building libbacktrace with Intel CET
libbacktrace/
* configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
* aclocal.m4: Regenerate.
* Makefile.in: Likewise.
* configure: Likewise.
---
libbacktrace/Makefile.in | 4 ++-
libbacktrace/aclocal.m4 | 2 ++
libbacktrace/configure | 80 +++++++++++++++++++++++++++++++++++++++++++++--
libbacktrace/configure.ac | 6 ++++
4 files changed, 89 insertions(+), 3 deletions(-)
diff --git a/libbacktrace/Makefile.in b/libbacktrace/Makefile.in
index 407098a..f7f849b 100644
--- a/libbacktrace/Makefile.in
+++ b/libbacktrace/Makefile.in
@@ -95,7 +95,9 @@ DIST_COMMON = README ChangeLog $(srcdir)/Makefile.in \
$(am__configure_deps) $(srcdir)/config.h.in \
$(srcdir)/../mkinstalldirs $(srcdir)/backtrace-supported.h.in
ACLOCAL_M4 = $(top_srcdir)/aclocal.m4
-am__aclocal_m4_deps = $(top_srcdir)/../config/lead-dot.m4 \
+am__aclocal_m4_deps = $(top_srcdir)/../config/cet.m4 \
+ $(top_srcdir)/../config/enable.m4 \
+ $(top_srcdir)/../config/lead-dot.m4 \
$(top_srcdir)/../config/multi.m4 \
$(top_srcdir)/../config/override.m4 \
$(top_srcdir)/../config/stdint.m4 \
diff --git a/libbacktrace/aclocal.m4 b/libbacktrace/aclocal.m4
index 8e84ddd..7a6ea55 100644
--- a/libbacktrace/aclocal.m4
+++ b/libbacktrace/aclocal.m4
@@ -670,6 +670,8 @@ AC_SUBST([am__tar])
AC_SUBST([am__untar])
]) # _AM_PROG_TAR
+m4_include([../config/cet.m4])
+m4_include([../config/enable.m4])
m4_include([../config/lead-dot.m4])
m4_include([../config/multi.m4])
m4_include([../config/override.m4])
diff --git a/libbacktrace/configure b/libbacktrace/configure
index 7ed9509..e7562af 100755
--- a/libbacktrace/configure
+++ b/libbacktrace/configure
@@ -743,6 +743,7 @@ enable_fast_install
with_gnu_ld
enable_libtool_lock
enable_largefile
+enable_cet
with_system_libunwind
enable_host_shared
'
@@ -1385,6 +1386,8 @@ Optional Features:
optimize for fast installation [default=yes]
--disable-libtool-lock avoid locking (might break parallel builds)
--disable-largefile omit support for large files
+ --enable-cet enable Intel CET in target libraries
+ [default=default]
--enable-host-shared build host code as shared libraries
Optional Packages:
@@ -11146,7 +11149,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 11149 "configure"
+#line 11152 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -11252,7 +11255,7 @@ else
lt_dlunknown=0; lt_dlno_uscore=1; lt_dlneed_uscore=2
lt_status=$lt_dlunknown
cat > conftest.$ac_ext <<_LT_EOF
-#line 11255 "configure"
+#line 11258 "configure"
#include "confdefs.h"
#if HAVE_DLFCN_H
@@ -11784,6 +11787,79 @@ $as_echo "$libbacktrace_cv_c_random_seed_string" >&6; }
fi
fi
+if test -n "${with_target_subdir}"; then
+ # Add CET specific flags is Intel CET is enabled.
+ # Check whether --enable-cet was given.
+if test "${enable_cet+set}" = set; then :
+ enableval=$enable_cet;
+ case "$enableval" in
+ yes|no|default) ;;
+ *) as_fn_error "Unknown argument to enable/disable cet" "$LINENO" 5 ;;
+ esac
+
+else
+ enable_cet=default
+fi
+
+
+case "$host" in
+ i3456786-*-linux* | x86_64-*-linux*)
+ enable_cet_compatibility=yes
+ case "$enable_cet" in
+ default)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+ enable_cet=yes
+else
+ enable_cet=no
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ yes)
+ # Check if assembler supports CET.
+ cat confdefs.h - <<_ACEOF >conftest.$ac_ext
+/* end confdefs.h. */
+
+int
+main ()
+{
+asm ("setssbsy");
+ ;
+ return 0;
+}
+_ACEOF
+if ac_fn_c_try_compile "$LINENO"; then :
+
+else
+ as_fn_error "assembler with CET support is required for --enable-cet" "$LINENO" 5
+fi
+rm -f core conftest.err conftest.$ac_objext conftest.$ac_ext
+ ;;
+ esac
+ ;;
+ *)
+ enable_cet=no
+ enable_cet_compatibility=no
+ ;;
+esac
+if test x$enable_cet = xyes; then
+ CET_FLAGS="-fcf-protection -mcet"
+fi
+
+ EXTRA_FLAGS="$EXTRA_FLAGS $CET_FLAGS"
+fi
+
ac_ext=c
ac_cpp='$CPP $CPPFLAGS'
diff --git a/libbacktrace/configure.ac b/libbacktrace/configure.ac
index 9bc1d0f..bca3c81 100644
--- a/libbacktrace/configure.ac
+++ b/libbacktrace/configure.ac
@@ -130,6 +130,12 @@ else
EXTRA_FLAGS="$EXTRA_FLAGS -frandom-seed=\$@"
fi
fi
+
+if test -n "${with_target_subdir}"; then
+ # Add CET specific flags is Intel CET is enabled.
+ GCC_CET_FLAGS(CET_FLAGS)
+ EXTRA_FLAGS="$EXTRA_FLAGS $CET_FLAGS"
+fi
AC_SUBST(EXTRA_FLAGS)
ACX_PROG_CC_WARNING_OPTS([-W -Wall -Wwrite-strings -Wstrict-prototypes \
--
1.8.3.1
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 09/22] Enable building libbacktrace with Intel CET
2017-10-31 11:49 ` Tsimbalist, Igor V
@ 2017-11-08 17:30 ` Jeff Law
0 siblings, 0 replies; 7+ messages in thread
From: Jeff Law @ 2017-11-08 17:30 UTC (permalink / raw)
To: Tsimbalist, Igor V, Ian Lance Taylor; +Cc: gcc-patches
On 10/31/2017 05:47 AM, Tsimbalist, Igor V wrote:
> The revised patch is attached. The differences are in what options are defined and propagated to Makefile for CET enabling. -iclude option is dropped, each needed asm file is processed separately.
>
> Igor
>
>
[ ... ]
>
>
> From d41da8a9f48e5b98d5e8e0e43805734c822e0caa Mon Sep 17 00:00:00 2001
> From: Igor Tsimbalist <igor.v.tsimbalist@intel.com>
> Date: Fri, 27 Oct 2017 15:56:39 +0300
> Subject: [PATCH 09/21] Enable building libbacktrace with Intel CET
>
> libbacktrace/
> * configure.ac: Add CET_FLAGS to EXTRA_FLAGS.
> * aclocal.m4: Regenerate.
> * Makefile.in: Likewise.
> * configure: Likewise.
OK. However, please wait to commit until the entire set is ACK'd.
Jeff
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2017-11-08 17:28 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-12 20:03 [PATCH 09/22] Enable building libbacktrace with Intel CET Tsimbalist, Igor V
2017-10-12 23:59 ` Ian Lance Taylor
2017-10-13 14:59 ` Jeff Law
2017-10-13 15:18 ` Tsimbalist, Igor V
2017-10-13 16:56 ` Ian Lance Taylor
2017-10-31 11:49 ` Tsimbalist, Igor V
2017-11-08 17:30 ` Jeff Law
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).