[PATCH, doc] PR30739: awk is a build prerequisite

[PATCH, doc] PR30739: awk is a build prerequisite

[Ralf Wildenhues]

I suppose nobody in those PRs (30739, 29049) remembers which gawk
versions were broken, so let's just go for a general mention.

According to 'info gawk SVR4', GCC needs at least SVR4 awk because
multiple -f options, -v, and regex constants are used during the build.
I haven't seen any Posix requirement in the scripts, at a quick glance.

Tested 'make html info pdf'.  OK for trunk?

Thanks,
Ralf

gcc/ChangeLog:
2008-06-14  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	PR documentation/30739
        * doc/install.texi (Prerequisites): Document dependency on awk.

diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index 127f065..50b135d 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -273,6 +273,12 @@ environment to your ``good'' shell prior to running
 @command{zsh} is not a fully compliant POSIX shell and will not
 work when configuring GCC@.
 
+@item A ``working'' SVR4 or POSIX awk
+
+Necessary for creating some of the generated source files for GCC@.
+If in doubt, use a recent GNU awk version, as some of the older ones
+are broken.
+
 @item GNU binutils
 
 Necessary in some circumstances, optional in others.  See the

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Ian Lance Taylor]

Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:

> gcc/ChangeLog:
> 2008-06-14  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
>
> 	PR documentation/30739
>         * doc/install.texi (Prerequisites): Document dependency on awk.

This is OK if you add a sentence like "GNU awk version 3.1.5 is known
to work."

Thanks.

Ian

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[NightStrike]

On 6/15/08, Ian Lance Taylor <iant@google.com> wrote:
> Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
>
> > gcc/ChangeLog:
> > 2008-06-14  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
> >
> >       PR documentation/30739
> >         * doc/install.texi (Prerequisites): Document dependency on awk.
>
> This is OK if you add a sentence like "GNU awk version 3.1.5 is known
> to work."

You could just declare that 3.1.5 is the minimum required version, right?

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Ian Lance Taylor]

NightStrike <nightstrike@gmail.com> writes:

> On 6/15/08, Ian Lance Taylor <iant@google.com> wrote:
>> Ralf Wildenhues <Ralf.Wildenhues@gmx.de> writes:
>>
>> > gcc/ChangeLog:
>> > 2008-06-14  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
>> >
>> >       PR documentation/30739
>> >         * doc/install.texi (Prerequisites): Document dependency on awk.
>>
>> This is OK if you add a sentence like "GNU awk version 3.1.5 is known
>> to work."
>
> You could just declare that 3.1.5 is the minimum required version, right?

I would prefer that somebody actually investigate the minimum required
version before we do that.

Ian

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Ralf Wildenhues]

* Ian Lance Taylor wrote on Mon, Jun 16, 2008 at 12:25:20AM CEST:
> NightStrike <nightstrike@gmail.com> writes:
> > On 6/15/08, Ian Lance Taylor <iant@google.com> wrote:
> >>
> >> This is OK if you add a sentence like "GNU awk version 3.1.5 is known
> >> to work."
> >
> > You could just declare that 3.1.5 is the minimum required version, right?
> 
> I would prefer that somebody actually investigate the minimum required
> version before we do that.

Well, I'd be a bit disappointed if GCC actually required gawk rather
than any POSIX awk, or even a very recent version of it; there'd have
to be a really good reason.  I can't claim that my quick glance was an
in-depth investigation, but I did not find any gawk-specifics so far;
and the PR in question rather suggests that there was some bug to be
avoided in one specific gawk version.

Feel free to Cc: me on awk portability issues, BTW.

* Gerald Pfeifer wrote on Wed, Jun 18, 2008 at 03:51:18PM CEST:
> On Sun, 15 Jun 2008, Ian Lance Taylor wrote:
> >> @item A ``working'' SVR4 or POSIX awk
> 
> Can we just make this "awk" or "POSIX or SVR4 awk"?  "working" should
> be implied,and we don't have this for the other tools, except for sh,
> admittedly, where I assume you've taken this from?

Well, I've looked at the gawk manual for relevant differences, and
picked the lowest common denominator first.

> Also, POSIX seems to be more relvant these days, so I'd put it first,
> but this is really, really nitpicking. ;-)

Fine with me.

Applied to trunk as below.  OK for 4.3 also (as that was what the PR was
filed against)?

Thanks everyone for the feedback,
Ralf

gcc/ChangeLog:
2008-06-18  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	PR documentation/30739
	* doc/install.texi (Prerequisites): Document dependency on awk.

diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi
index d21becf..8292fbf 100644
--- a/gcc/doc/install.texi
+++ b/gcc/doc/install.texi
@@ -273,6 +273,12 @@ environment to your ``good'' shell prior to running
 @command{zsh} is not a fully compliant POSIX shell and will not
 work when configuring GCC@.
 
+@item A POSIX or SVR4 awk
+
+Necessary for creating some of the generated source files for GCC@.
+If in doubt, use a recent GNU awk version, as some of the older ones
+are broken.  GNU awk version 3.1.5 is known to work.
+
 @item GNU binutils
 
 Necessary in some circumstances, optional in others.  See the

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Andrew Pinski]

Ok I found the old emails about what version of GNU awk caused the
issues, it was 3.1.2.
See the thread starting at
http://gcc.gnu.org/ml/gcc-patches/2003-06/msg01894.html .
It was released part of a cygwin release.

Thanks,
Andrew Pinski

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Ralf Wildenhues]

* Andrew Pinski wrote on Wed, Jun 18, 2008 at 08:52:23PM CEST:
> Ok I found the old emails about what version of GNU awk caused the
> issues, it was 3.1.2.
> See the thread starting at
> http://gcc.gnu.org/ml/gcc-patches/2003-06/msg01894.html .
> It was released part of a cygwin release.

Thanks for digging it out.  The bug is limited to RS="" which was
subsequently worked around, and which isn't present in the current
tree, either.

So we could just leave it at that, or add a note, since code using
RS="" may be introduced again.  OK as below (and both for 4.3, too)?

Thanks,
Ralf

gcc/ChangeLog:
2008-06-18  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>

	PR documentation/30739
	* doc/install.texi (Prerequisites): List broken awk version.

Index: gcc/doc/install.texi
===================================================================
--- gcc/doc/install.texi	(Revision 136902)
+++ gcc/doc/install.texi	(Arbeitskopie)
@@ -277,7 +277,8 @@
 
 Necessary for creating some of the generated source files for GCC@.
 If in doubt, use a recent GNU awk version, as some of the older ones
-are broken.  GNU awk version 3.1.5 is known to work.
+are broken.  GNU awk version 3.1.2 had a problem with code using
+@code{RS=""}; version 3.1.5 is known to work.
 
 @item GNU binutils
 

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Gerald Pfeifer]

On Wed, 18 Jun 2008, Ralf Wildenhues wrote:
> Applied to trunk as below.  OK for 4.3 also (as that was what the PR
> was filed against)?

Yes, please.

Gerald

Re: [PATCH, doc] PR30739: awk is a build prerequisite

[Gerald Pfeifer]

On Sun, 15 Jun 2008, Ian Lance Taylor wrote:
>> 2008-06-14  Ralf Wildenhues  <Ralf.Wildenhues@gmx.de>
>>
>> 	PR documentation/30739
>>         * doc/install.texi (Prerequisites): Document dependency on awk.
>> [...]
>> @item A ``working'' SVR4 or POSIX awk

Can we just make this "awk" or "POSIX or SVR4 awk"?  "working" should
be implied,and we don't have this for the other tools, except for sh,
admittedly, where I assume you've taken this from?  Also, POSIX seems
to be more relvant these days, so I'd put it first, but this is really,
really nitpicking. ;-)

Gerald