* [PATCH] Remove 2 dead lines from java_mangle_decl
@ 2008-03-12 15:50 Paolo Bonzini
2008-03-12 17:00 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Paolo Bonzini @ 2008-03-12 15:50 UTC (permalink / raw)
To: GCC Patches, Tom Tromey
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
If these two lines were ever executed, GCC would die soon after with an
assertion failure (I created the patch with big context for making this
evident).
Ok?
Paolo
[-- Attachment #2: java-mangle-decl.patch --]
[-- Type: text/plain, Size: 896 bytes --]
2008-03-12 Paolo Bonzini <bonzini@gnu.org>
* mangle.c (java_mangle_decl): Remove dead code.
Index: mangle.c
===================================================================
*** mangle.c (revision 133143)
--- mangle.c (working copy)
*************** cxx_keyword_p (const char *name, int len
*** 239,254 ****
void
java_mangle_decl (tree decl)
{
- if (TREE_CODE (decl) == RECORD_TYPE)
- mangle_type (decl);
-
/* A copy of the check from the beginning of lhd_set_decl_assembler_name.
Only FUNCTION_DECLs and VAR_DECLs for variables with static storage
duration need a real DECL_ASSEMBLER_NAME. */
gcc_assert (TREE_CODE (decl) == FUNCTION_DECL
|| (TREE_CODE (decl) == VAR_DECL
&& (TREE_STATIC (decl)
|| DECL_EXTERNAL (decl)
|| TREE_PUBLIC (decl))));
/* Mangling only applies to class members. */
--- 232,251 ----
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Remove 2 dead lines from java_mangle_decl
2008-03-12 15:50 [PATCH] Remove 2 dead lines from java_mangle_decl Paolo Bonzini
@ 2008-03-12 17:00 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2008-03-12 17:00 UTC (permalink / raw)
To: Paolo Bonzini; +Cc: GCC Patches
Paolo> If these two lines were ever executed, GCC would die soon after with
Paolo> an assertion failure (I created the patch with big context for making
Paolo> this evident).
Paolo> Ok?
Looks good to me. Please check it in. Thanks.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-03-12 17:00 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-03-12 15:50 [PATCH] Remove 2 dead lines from java_mangle_decl Paolo Bonzini
2008-03-12 17:00 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).