From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28414 invoked by alias); 13 Oct 2009 17:21:06 -0000 Received: (qmail 28346 invoked by uid 22791); 13 Oct 2009 17:21:05 -0000 X-SWARE-Spam-Status: No, hits=-2.5 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Tue, 13 Oct 2009 17:20:53 +0000 Received: from int-mx03.intmail.prod.int.phx2.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by mx1.redhat.com (8.13.8/8.13.8) with ESMTP id n9DHKprt004871 for ; Tue, 13 Oct 2009 13:20:52 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx03.intmail.prod.int.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id n9DHKpxW029238; Tue, 13 Oct 2009 13:20:51 -0400 Received: from opsy.redhat.com (ovpn01.gateway.prod.ext.phx2.redhat.com [10.5.9.1]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id n9DHKot4024350; Tue, 13 Oct 2009 13:20:50 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id 2A3F9378216; Tue, 13 Oct 2009 11:20:49 -0600 (MDT) From: Tom Tromey To: Jakub Jelinek Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Raw strings (take 3) References: <20091012122237.GJ14664@tyan-ft48-01.lab.bos.redhat.com> <20091013140022.GS14664@tyan-ft48-01.lab.bos.redhat.com> Reply-To: Tom Tromey Date: Tue, 13 Oct 2009 17:24:00 -0000 In-Reply-To: <20091013140022.GS14664@tyan-ft48-01.lab.bos.redhat.com> (Jakub Jelinek's message of "Tue, 13 Oct 2009 16:00:22 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg00855.txt.bz2 >>>>> "Jakub" == Jakub Jelinek writes: Tom> Would it be too much trouble to use calls to cpp_error_with_line for all Tom> new errors? I think this is generally preferable, and in this code I Tom> think it would also let us emit errors against locations inside strings. Tom> (And, for errors about unterminated strings, it would let us point to Tom> the start of the string, which seems better to me.) Jakub> Done. Thanks! Jakub> 2009-10-13 Jakub Jelinek Jakub> * charset.c (cpp_init_iconv): Initialize utf8_cset_desc. [...] The parts of this that I can approve are ok. Thanks again. Tom