public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Michael Matz <matz@suse.de>
Cc: Andreas Krebbel <Andreas.Krebbel@de.ibm.com>,
	        Rask Ingemann Lambertsen <rask@sygehus.dk>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] lower-subreg: Decompose multiword shifts
Date: Tue, 07 Aug 2007 01:08:00 -0000	[thread overview]
Message-ID: <m3vebsp30q.fsf@localhost.localdomain> (raw)
In-Reply-To: <Pine.LNX.4.64.0708031710320.23011@wotan.suse.de>

Michael Matz <matz@suse.de> writes:

> ... this would be wrong of lower-subreg.  I thought it handled libcall 
> sequences correctly, Ian?  If lower-subreg manages to decompose _all_ 
> writing subreg references in the libcall sequence then the whole libcall 
> structure can and should be removed (which includes the introducing 
> clobber and the finishing self-move (with the RETVAL note)).  Removing 
> only part of that structure is going to cause confusion later on (as 
> here).

Well, I think it handles libcalls correctly, but I see now that the
sequences emitted by emit_no_conflict_block get a bit strange.
lower-subreg is going to tend to throw away the work done by
emit_no_conflict_block, in that it will decompose the registers making
the REG_NO_CONFLICT notes useless.  I think the result is still
correct, except that the initial clobbers are now useless.

I'm testing a patch to remove that initial clobber.

Ian

  reply	other threads:[~2007-08-07  1:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-02 15:35 Andreas Krebbel
2007-08-02 16:56 ` Paolo Bonzini
2007-08-03 16:41   ` Andreas Krebbel
2007-08-03 19:02     ` Paolo Bonzini
2007-08-02 18:52 ` Rask Ingemann Lambertsen
2007-08-02 19:21   ` Andreas Krebbel
2007-08-07  1:41     ` Rask Ingemann Lambertsen
2007-08-07  8:29       ` Andreas Krebbel
2007-08-02 23:16 ` Rask Ingemann Lambertsen
2007-08-03 12:03   ` Michael Matz
2007-08-03 14:34   ` Andreas Krebbel
2007-08-03 15:37     ` Michael Matz
2007-08-07  1:08       ` Ian Lance Taylor [this message]
2007-08-07  1:27 ` Ian Lance Taylor
2007-08-07 10:47   ` Andreas Krebbel
2007-08-08 18:40     ` Andreas Tobler
2007-08-09  7:45       ` Andreas Krebbel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m3vebsp30q.fsf@localhost.localdomain \
    --to=iant@google.com \
    --cc=Andreas.Krebbel@de.ibm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=matz@suse.de \
    --cc=rask@sygehus.dk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).