From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5243 invoked by alias); 13 Sep 2008 01:06:32 -0000 Received: (qmail 5221 invoked by uid 22791); 13 Sep 2008 01:06:32 -0000 X-Spam-Check-By: sourceware.org Received: from mx2.redhat.com (HELO mx2.redhat.com) (66.187.237.31) by sourceware.org (qpsmtpd/0.31) with ESMTP; Sat, 13 Sep 2008 01:05:46 +0000 Received: from int-mx2.corp.redhat.com (int-mx2.corp.redhat.com [172.16.27.26]) by mx2.redhat.com (8.13.8/8.13.8) with ESMTP id m8D14rDb027043; Fri, 12 Sep 2008 21:05:13 -0400 Received: from ns3.rdu.redhat.com (ns3.rdu.redhat.com [10.11.255.199]) by int-mx2.corp.redhat.com (8.13.1/8.13.1) with ESMTP id m8D14fWF004465; Fri, 12 Sep 2008 21:04:42 -0400 Received: from opsy.redhat.com (vpn-10-13.bos.redhat.com [10.16.10.13]) by ns3.rdu.redhat.com (8.13.8/8.13.8) with ESMTP id m8D14et3023496; Fri, 12 Sep 2008 21:04:40 -0400 Received: by opsy.redhat.com (Postfix, from userid 500) id C0DC188803A; Fri, 12 Sep 2008 19:04:50 -0600 (MDT) To: Simon Baldwin Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH][RFC] -Wno-... option to suppress builtin macro redefined warnings References: <20080730140920.0F9CF3FE1B9@localhost> <489C728B.4040505@google.com> <48A5B2C6.1090600@google.com> <48AEE7A7.9000509@google.com> <48B42327.1090204@google.com> From: Tom Tromey Reply-To: Tom Tromey X-Attribution: Tom Date: Sat, 13 Sep 2008 07:42:00 -0000 In-Reply-To: <48B42327.1090204@google.com> (Simon Baldwin's message of "Tue\, 26 Aug 2008 16\:37\:11 +0100") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2008-09/txt/msg01014.txt.bz2 >>>>> "Simon" == Simon Baldwin writes: Simon> ...so, attached below is a re-draft of this patch to bifurcate Simon> built-in macros so that only TIMESTAMP, TIME, DATE, FILE, and Simon> FILE_BASE are affected by -Wno-builtin-macro-redefined, and other Simon> built-in macros always warn if redefined. Simon> Please take another look when time permits, to see if you like this Simon> version better than the first. And thanks again for the feedback. I can only approve the libcpp parts -- those are ok. thanks, Tom