From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-195622-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 27667 invoked by alias); 24 May 2007 19:21:36 -0000
Received: (qmail 27654 invoked by uid 22791); 24 May 2007 19:21:34 -0000
X-Spam-Check-By: sourceware.org
Received: from mx1.redhat.com (HELO mx1.redhat.com) (66.187.233.31)     by sourceware.org (qpsmtpd/0.31) with ESMTP; Thu, 24 May 2007 19:21:25 +0000
Received: from int-mx1.corp.redhat.com (int-mx1.corp.redhat.com [172.16.52.254]) 	by mx1.redhat.com (8.13.1/8.13.1) with ESMTP id l4OJLLFp002736; 	Thu, 24 May 2007 15:21:22 -0400
Received: from pobox.corp.redhat.com (pobox.corp.redhat.com [10.11.255.20]) 	by int-mx1.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l4OJLLrp014747; 	Thu, 24 May 2007 15:21:21 -0400
Received: from opsy.redhat.com (ton.toronto.redhat.com [172.16.14.15]) 	by pobox.corp.redhat.com (8.13.1/8.13.1) with ESMTP id l4OJL7n3001259; 	Thu, 24 May 2007 15:21:07 -0400
Received: by opsy.redhat.com (Postfix, from userid 500) 	id 395F037809B; Thu, 24 May 2007 13:01:06 -0600 (MDT)
To: "Ollie Wild" <aaw@google.com>
Cc: "GCC Patches" <gcc-patches@gcc.gnu.org>,         "Dave Korn" <dave.korn@artimi.com>,         "Basile STARYNKEVITCH" <basile@starynkevitch.net>,         "Ian Lance Taylor" <iant@google.com>
Subject: Re: PATCH: Adds a __COUNTER__ macro.
References: <65dd6fd50705231434h2a9a8bf1h3ee9a7b2a19c2823@mail.gmail.com>
From: Tom Tromey <tromey@redhat.com>
Reply-To: tromey@redhat.com
X-Attribution:  Tom
Date: Thu, 24 May 2007 19:23:00 -0000
In-Reply-To: <65dd6fd50705231434h2a9a8bf1h3ee9a7b2a19c2823@mail.gmail.com> (Ollie Wild's message of "Wed\, 23 May 2007 14\:34\:11 -0700")
Message-ID: <m3y7je59n1.fsf@fleche.redhat.com>
User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.0.95 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
X-SW-Source: 2007-05/txt/msg01638.txt.bz2

>>>>> "Ollie" == Ollie Wild <aaw@google.com> writes:

Ollie> This patch adds a builtin __COUNTER__ macro which expands to
Ollie> incrementing integral values starting from 0.  In conjunction with the
Ollie> '##' operator, this is useful for generating unique identifiers.  Per
Ollie> my comments at http://gcc.gnu.org/ml/gcc-patches/2007-05/msg01488.html,
Ollie> this does not include some additional logic to integrate with the
Ollie> pending -fdirectives-only patch.

Ollie> Tested with a full bootstrap and testsuite run on i686-pc-linux-gnu.

Looks good to me.  Thanks.

Tom