From: Dodji Seketeli <dodji@redhat.com>
To: "Ulrich Weigand" <uweigand@de.ibm.com>
Cc: gcc-patches@gcc.gnu.org, jason@redhat.com, tromey@redhat.com,
gdr@integrable-solutions.net, joseph@codesourcery.com,
burnus@net-b.de, charlet@act-europe.fr
Subject: Re: [PATCH 2/6] Generate virtual locations for tokens
Date: Wed, 19 Oct 2011 17:11:00 -0000 [thread overview]
Message-ID: <m3zkgxos9h.fsf@redhat.com> (raw)
In-Reply-To: <201110191359.p9JDxAgL021398@d06av02.portsmouth.uk.ibm.com> (Ulrich Weigand's message of "Wed, 19 Oct 2011 15:59:09 +0200 (CEST)")
"Ulrich Weigand" <uweigand@de.ibm.com> writes:
> The problem seems to be that the preprocessor somehow stripped
> off the "unsigned" keyword. A reduced test case is:
>
> #define isinf(__x)
>
> #define vec_uint4 __vector unsigned int
>
> vec_uint4 isinf;
>
> (Using the name of a function-like macro as identifer is maybe a bit odd,
> but should be perfectly legal C as far as I know ...)
>
> Running this through "cc1 -E" on a SPU target before the patch set yields:
>
> __attribute__((__spu_vector__)) unsigned int isinf;
>
> as expected, but after the patch set we get:
>
> __attribute__((__spu_vector__)) int isinf;
>
> instead.
>
> The problem is clearly related to the platform-specific "macro_to_expand"
> routine that is used on SPU to implement the context-sensitive __vector
> keyword.
>
> With your changes to cpp_get_token (which is the sole caller of the
> macro_to_expand callback), are there any changes in the interface
> to the callback?
Not that I would expect.
> Any suggestions what could be going on here?
Nothing obvious is coming to my mind right now, I am still looking
at the issue.
--
Dodji
next prev parent reply other threads:[~2011-10-19 16:34 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-17 9:58 [PATCH 0/6] Tracking locations of tokens resulting from macro expansion Dodji Seketeli
2011-10-17 9:58 ` [PATCH 3/6] Emit macro expansion related diagnostics Dodji Seketeli
2011-10-17 10:56 ` Richard Guenther
2011-10-17 12:22 ` Dodji Seketeli
2011-10-17 14:11 ` Dodji Seketeli
2011-10-17 17:41 ` H.J. Lu
2011-10-18 0:29 ` Dodji Seketeli
2011-10-18 6:07 ` Jason Merrill
2011-10-18 9:22 ` Dodji Seketeli
2011-10-17 10:08 ` [PATCH 4/6] Support -fdebug-cpp option Dodji Seketeli
2011-10-17 10:19 ` [PATCH 6/6] Reduce memory waste due to non-power-of-2 allocs Dodji Seketeli
2011-10-17 10:22 ` [PATCH 5/6] Add line map statistics to -fmem-report output Dodji Seketeli
2011-10-17 10:25 ` [PATCH 1/6] Linemap infrastructure for virtual locations Dodji Seketeli
2011-10-17 19:53 ` Gerald Pfeifer
2011-10-17 20:44 ` Dodji Seketeli
2011-10-18 7:24 ` Gerald Pfeifer
2011-10-18 9:44 ` Dodji Seketeli
2011-10-17 10:26 ` [PATCH 2/6] Generate virtual locations for tokens Dodji Seketeli
2011-10-19 14:48 ` Ulrich Weigand
2011-10-19 17:11 ` Dodji Seketeli [this message]
2011-10-19 20:42 ` Dodji Seketeli
-- strict thread matches above, loose matches on Subject: below --
2010-12-10 11:27 [PATCH 0/6] Tracking locations of tokens resulting from macro expansion Dodji Seketeli
2010-12-10 12:27 ` [PATCH 2/6] Generate virtual locations for tokens Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m3zkgxos9h.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=burnus@net-b.de \
--cc=charlet@act-europe.fr \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdr@integrable-solutions.net \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=tromey@redhat.com \
--cc=uweigand@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).