public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Ian Lance Taylor <iant@google.com>
To: Richard Guenther <richard.guenther@gmail.com>, edelsohn@gnu.org
Cc: Paolo Bonzini <bonzini@gnu.org>, gcc-patches@gcc.gnu.org
Subject: Re: PATCH RFA: Build system: Use AC_SYS_LARGEFILE
Date: Wed, 03 Nov 2010 15:41:00 -0000	[thread overview]
Message-ID: <mcr1v72o265.fsf@google.com> (raw)
In-Reply-To: <AANLkTim-GBnF2CD-WrTp_FsNUrfF8Aqm5UZGKg6Xkgto@mail.gmail.com>	(Richard Guenther's message of "Wed, 3 Nov 2010 15:41:33 +0100")

Richard Guenther <richard.guenther@gmail.com> writes:

> On Wed, Nov 3, 2010 at 3:30 PM, Ian Lance Taylor <iant@google.com> wrote:
>> Richard Guenther <richard.guenther@gmail.com> writes:
>>
>>> I did this once and had to revert it again because it broke bootstrap
>>> on AIX in some obscure way.  But yes, we carry this patch in our
>>> local GCC versions since a few major releases.
>>
>> Perhaps the problem then was that libiberty did not use
>> AC_SYS_LARGEFILE?  That was added to libiberty 2008-10-07.
>>
>> In any case I committed the patch.
>
> FYI, http://gcc.gnu.org/ml/gcc-patches/2009-02/msg00706.html

Thanks.  I checked a bunch of .c files in gcc and libcpp, and they all
reliably #included "config.h" first.  I didn't check every file, but I
didn't find any exceptions to the rule.  So I think this is fixable.

David, can you let us know what fails when bootstrapping current
mainline on AIX?

Ian

  reply	other threads:[~2010-11-03 15:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-02 22:21 Ian Lance Taylor
2010-11-03  1:01 ` Paolo Bonzini
2010-11-03  8:29   ` Jakub Jelinek
2010-11-03 10:49   ` Richard Guenther
2010-11-03 10:49     ` Paolo Bonzini
2010-11-03 14:41     ` Ian Lance Taylor
2010-11-03 14:51       ` Richard Guenther
2010-11-03 15:41         ` Ian Lance Taylor [this message]
2010-11-09 14:15 David Edelsohn
2010-11-09 14:19 ` Paolo Bonzini
2010-11-09 14:19   ` David Edelsohn
2010-11-09 15:26 ` Ian Lance Taylor
2010-11-09 15:35   ` David Edelsohn
2010-11-09 16:52     ` Ian Lance Taylor
2010-11-09 16:55       ` Paolo Bonzini
2010-11-09 18:19         ` David Edelsohn
2010-11-09 18:37           ` Ian Lance Taylor
2010-11-11 16:27         ` David Edelsohn
2010-11-11 19:58           ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mcr1v72o265.fsf@google.com \
    --to=iant@google.com \
    --cc=bonzini@gnu.org \
    --cc=edelsohn@gnu.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=richard.guenther@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).