From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30368 invoked by alias); 3 Nov 2010 15:30:23 -0000 Received: (qmail 30351 invoked by uid 22791); 3 Nov 2010 15:30:21 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 03 Nov 2010 15:30:17 +0000 Received: from kpbe18.cbf.corp.google.com (kpbe18.cbf.corp.google.com [172.25.105.82]) by smtp-out.google.com with ESMTP id oA3FUEl6007704 for ; Wed, 3 Nov 2010 08:30:14 -0700 Received: from pvg7 (pvg7.prod.google.com [10.241.210.135]) by kpbe18.cbf.corp.google.com with ESMTP id oA3FTv5R013038 for ; Wed, 3 Nov 2010 08:30:13 -0700 Received: by pvg7 with SMTP id 7so301175pvg.36 for ; Wed, 03 Nov 2010 08:30:12 -0700 (PDT) Received: by 10.142.135.13 with SMTP id i13mr6952075wfd.21.1288798212686; Wed, 03 Nov 2010 08:30:12 -0700 (PDT) Received: from coign.google.com (dhcp-172-22-125-232.mtv.corp.google.com [172.22.125.232]) by mx.google.com with ESMTPS id w23sm2035117wfd.21.2010.11.03.08.30.11 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 03 Nov 2010 08:30:11 -0700 (PDT) From: Ian Lance Taylor To: Richard Guenther , edelsohn@gnu.org Cc: Paolo Bonzini , gcc-patches@gcc.gnu.org Subject: Re: PATCH RFA: Build system: Use AC_SYS_LARGEFILE References: <4CD0AEF6.1000709@gnu.org> Date: Wed, 03 Nov 2010 15:41:00 -0000 In-Reply-To: (Richard Guenther's message of "Wed, 3 Nov 2010 15:41:33 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg00301.txt.bz2 Richard Guenther writes: > On Wed, Nov 3, 2010 at 3:30 PM, Ian Lance Taylor wrote: >> Richard Guenther writes: >> >>> I did this once and had to revert it again because it broke bootstrap >>> on AIX in some obscure way. =C2=A0But yes, we carry this patch in our >>> local GCC versions since a few major releases. >> >> Perhaps the problem then was that libiberty did not use >> AC_SYS_LARGEFILE? =C2=A0That was added to libiberty 2008-10-07. >> >> In any case I committed the patch. > > FYI, http://gcc.gnu.org/ml/gcc-patches/2009-02/msg00706.html Thanks. I checked a bunch of .c files in gcc and libcpp, and they all reliably #included "config.h" first. I didn't check every file, but I didn't find any exceptions to the rule. So I think this is fixable. David, can you let us know what fails when bootstrapping current mainline on AIX? Ian