* Go patch committed: Avoid memory overrun for bogus file name
@ 2014-04-30 2:52 Ian Lance Taylor
0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2014-04-30 2:52 UTC (permalink / raw)
To: gcc-patches, gofrontend-dev
[-- Attachment #1: Type: text/plain, Size: 290 bytes --]
Dominik Vogt pointed out a problem in the Go frontend: it could
overwrite memory incorrectly if an archive contains a file whose name is
only spaces. This patch fixes the problem. Bootstrapped and ran Go
testsuite on x86_64-unknown-linux-gnu. Committed to mainline and 4.9
branch.
Ian
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: patch --]
[-- Type: text/x-diff, Size: 421 bytes --]
diff -r e403fdfd3005 go/import-archive.cc
--- a/go/import-archive.cc Fri Apr 25 20:32:52 2014 -0700
+++ b/go/import-archive.cc Tue Apr 29 22:32:40 2014 -0400
@@ -261,7 +261,7 @@
char size_string[size_string_size + 1];
memcpy(size_string, hdr->ar_size, size_string_size);
char* ps = size_string + size_string_size;
- while (ps[-1] == ' ')
+ while (ps > size_string && ps[-1] == ' ')
--ps;
*ps = '\0';
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2014-04-30 2:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-04-30 2:52 Go patch committed: Avoid memory overrun for bogus file name Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).