From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 4741 invoked by alias); 13 Apr 2011 04:02:47 -0000 Received: (qmail 4726 invoked by uid 22791); 13 Apr 2011 04:02:46 -0000 X-SWARE-Spam-Status: No, hits=-2.2 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.67) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 13 Apr 2011 04:02:39 +0000 Received: from wpaz5.hot.corp.google.com (wpaz5.hot.corp.google.com [172.24.198.69]) by smtp-out.google.com with ESMTP id p3D42Xoi004022 for ; Tue, 12 Apr 2011 21:02:35 -0700 Received: from iwn2 (iwn2.prod.google.com [10.241.68.66]) by wpaz5.hot.corp.google.com with ESMTP id p3D42VLX014320 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Tue, 12 Apr 2011 21:02:31 -0700 Received: by iwn2 with SMTP id 2so286806iwn.26 for ; Tue, 12 Apr 2011 21:02:31 -0700 (PDT) Received: by 10.42.163.138 with SMTP id c10mr2025797icy.269.1302667351298; Tue, 12 Apr 2011 21:02:31 -0700 (PDT) Received: from coign.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net [71.133.8.30]) by mx.google.com with ESMTPS id o3sm120035ibd.44.2011.04.12.21.02.29 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 12 Apr 2011 21:02:30 -0700 (PDT) From: Ian Lance Taylor To: Nathan Froyd Cc: gcc-patches@gcc.gnu.org, dnovillo@google.com Subject: Re: [PATCH 02/18] enforce TREE_CHAIN and TREE_TYPE accesses References: <1299817406-16745-1-git-send-email-froydnj@codesourcery.com> <1299817406-16745-3-git-send-email-froydnj@codesourcery.com> <20110413024341.GT23480@codesourcery.com> Date: Wed, 13 Apr 2011 04:02:00 -0000 In-Reply-To: <20110413024341.GT23480@codesourcery.com> (Nathan Froyd's message of "Tue, 12 Apr 2011 19:43:41 -0700") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg00961.txt.bz2 Nathan Froyd writes: > On Thu, Mar 10, 2011 at 11:23:10PM -0500, Nathan Froyd wrote: >> Now that we have a structure where not every node might include >> TREE_CHAIN or TREE_TYPE, we need to make sure that when we call said >> accessors that the argument is properly typed. This requires a number >> of changes: > > http://gcc.gnu.org/ml/gcc-patches/2011-03/msg00565.html > > Ping. I was going to commit this, but I realized I hadn't received > approval for the go or LTO bits. They probably qualify as obvious, > given that they're exactly the same as all the other languages, but just > to rubber-stamp everything... > >> gcc/go/ >> * go-lang.c (union lang_tree_node): Check for TS_COMMON before >> calling TREE_CHAIN. >> >> gcc/lto/ >> * lto-tree.h (union lang_tree_node): Check for TS_COMMON before >> calling TREE_CHAIN. >> * lto.c (lto_fixup_common): Likewise. This is OK. Thanks. Ian