From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 24518 invoked by alias); 17 Nov 2010 00:49:59 -0000 Received: (qmail 24510 invoked by uid 22791); 17 Nov 2010 00:49:58 -0000 X-SWARE-Spam-Status: No, hits=-4.7 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,RCVD_IN_DNSWL_HI,SPF_HELO_PASS,TW_CC,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (74.125.121.35) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 17 Nov 2010 00:49:53 +0000 Received: from wpaz1.hot.corp.google.com (wpaz1.hot.corp.google.com [172.24.198.65]) by smtp-out.google.com with ESMTP id oAH0n5WJ004991 for ; Tue, 16 Nov 2010 16:49:05 -0800 Received: from yxe42 (yxe42.prod.google.com [10.190.2.42]) by wpaz1.hot.corp.google.com with ESMTP id oAH0n3ol011863 for ; Tue, 16 Nov 2010 16:49:04 -0800 Received: by yxe42 with SMTP id 42so888268yxe.9 for ; Tue, 16 Nov 2010 16:49:03 -0800 (PST) Received: by 10.150.211.5 with SMTP id j5mr12607870ybg.425.1289954943825; Tue, 16 Nov 2010 16:49:03 -0800 (PST) Received: from coign.google.com ([67.218.104.238]) by mx.google.com with ESMTPS id v12sm4270752ybk.23.2010.11.16.16.49.01 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 16 Nov 2010 16:49:03 -0800 (PST) From: Ian Lance Taylor To: "Joseph S. Myers" Cc: gcc-patches@gcc.gnu.org Subject: Re: Go front end review: files outside gofrontend/ References: Date: Wed, 17 Nov 2010 02:15:00 -0000 In-Reply-To: (Joseph S. Myers's message of "Wed, 17 Nov 2010 00:29:33 +0000 (UTC)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2010-11/txt/msg01760.txt.bz2 "Joseph S. Myers" writes: > On Tue, 16 Nov 2010, Ian Lance Taylor wrote: > >> > are generally more sensible than the cargo-culted rules in other >> > directories that involve checking for a -cross binary and possibly >> > installing a non-functioning copy of the driver in $(gcc_tooldir)/bin/. >> > But if you have these rules you shouldn't still have the -cross binary. >> > And I think the *correct* rules everywhere ought to involve installing the >> > $(target_noncanonical)-{gcc,g++,gccgo,etc.} driver everywhere (though most >> > languages install one for both native and cross, this patch would not >> > install one for gccgo for native) and not installing any copies in >> > $(gcc_tooldir)/bin/ - furthermore, at least the $(INSTALL_PROGRAM) >> > commands should not ignore errors. >> >> This rule does install gccgo for native, so I'm not sure what you mean >> there. I changed this to not ignore the exit status of the > > What I'm referring to is the installation of $(target_noncanonical)-gccgo. > For example, there's a $(target_noncanonical)-gcc binary for native as > well as for cross. Oh yeah. Sorry for being dense. I committed a patch to the gccgo branch to fix this. Thanks. Ian