* [libgo] Fix __go_append declaration
@ 2011-04-18 14:22 Rainer Orth
2011-04-18 17:39 ` Ian Lance Taylor
0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2011-04-18 14:22 UTC (permalink / raw)
To: gcc-patches; +Cc: Ian Lance Taylor
An IRIX 6.5 bootstrap over the weekend broke in libgo:
/vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:22:1: error: conflicting types for '__go_append'
/vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:18:1: note: previous declaration of '__go_append' was here
make[4]: *** [go-append.lo] Error 1
The following patch allows the build to continue and seems to be the
correct fix, given that it matches go/gofrontend/runtime.def:
DEF_GO_RUNTIME(APPEND, "__go_append", P4(SLICE, POINTER, UINTPTR, UINTPTR),
Rainer
2011-04-18 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
* runtime/go-append.c (__go_append): Change size_t to uintptr_t.
diff --git a/libgo/runtime/go-append.c b/libgo/runtime/go-append.c
--- a/libgo/runtime/go-append.c
+++ b/libgo/runtime/go-append.c
@@ -15,7 +15,7 @@
this, we will always split the stack, because of memcpy and
memmove. */
extern struct __go_open_array
-__go_append (struct __go_open_array, void *, size_t, size_t)
+__go_append (struct __go_open_array, void *, uintptr_t, uintptr_t)
__attribute__ ((no_split_stack));
struct __go_open_array
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [libgo] Fix __go_append declaration
2011-04-18 14:22 [libgo] Fix __go_append declaration Rainer Orth
@ 2011-04-18 17:39 ` Ian Lance Taylor
0 siblings, 0 replies; 2+ messages in thread
From: Ian Lance Taylor @ 2011-04-18 17:39 UTC (permalink / raw)
To: Rainer Orth; +Cc: gcc-patches, gofrontend-dev
Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE> writes:
> An IRIX 6.5 bootstrap over the weekend broke in libgo:
>
> /vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:22:1: error: conflicting types for '__go_append'
> /vol/gcc/src/hg/trunk/local/libgo/runtime/go-append.c:18:1: note: previous declaration of '__go_append' was here
> make[4]: *** [go-append.lo] Error 1
>
> The following patch allows the build to continue and seems to be the
> correct fix, given that it matches go/gofrontend/runtime.def:
>
> DEF_GO_RUNTIME(APPEND, "__go_append", P4(SLICE, POINTER, UINTPTR, UINTPTR),
>
> Rainer
>
>
> 2011-04-18 Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>
>
> * runtime/go-append.c (__go_append): Change size_t to uintptr_t.
>
> diff --git a/libgo/runtime/go-append.c b/libgo/runtime/go-append.c
> --- a/libgo/runtime/go-append.c
> +++ b/libgo/runtime/go-append.c
> @@ -15,7 +15,7 @@
> this, we will always split the stack, because of memcpy and
> memmove. */
> extern struct __go_open_array
> -__go_append (struct __go_open_array, void *, size_t, size_t)
> +__go_append (struct __go_open_array, void *, uintptr_t, uintptr_t)
> __attribute__ ((no_split_stack));
>
> struct __go_open_array
Thanks.
Committed.
Ian
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-04-18 17:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-04-18 14:22 [libgo] Fix __go_append declaration Rainer Orth
2011-04-18 17:39 ` Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).