[PATCH, MELT] correcting path error in the Makefile.in

[PATCH, MELT] correcting path error in the Makefile.in

[Pierre Vittet]

[-- Attachment #1: Type: text/plain, Size: 392 bytes --]

This patch correct a bug in the current revision of MELT, which was 
preventing MELT to run correctly.

This was a path problem in gcc/Makefile.in (melt-modules/ and 
melt-modules.mk) were not found.

My contributor number is 634276.

changelog :


2011-05-17  Pierre Vittet  <piervit@pvittet.com>

	* Makefile.in : Correct path errors for melt_module_dir and for
	install-melt-mk target





[-- Attachment #2: correct_makefilein.diff --]
[-- Type: text/plain, Size: 1034 bytes --]

Index: gcc/Makefile.in
===================================================================
--- gcc/Makefile.in	(revision 173832)
+++ gcc/Makefile.in	(working copy)
@@ -5352,7 +5352,7 @@ melt_default_modules_list=melt-default-modules
 melt_source_dir=$(libexecsubdir)/melt-source/
 
 ## this is the installation directory of melt dynamic modules (*.so)
-melt_module_dir=$(libexecsubdir)/melt-module/
+melt_module_dir=$(libexecsubdir)/melt-modules/
 
 ## this is the installed path of the MELT module makefile
 melt_installed_module_makefile=$(libexecsubdir)/melt-module.mk
@@ -5416,8 +5416,8 @@ install-melt-modules: melt-modules melt-all-module
 
 ## install the makefile for MELT modules
 install-melt-mk: melt-module.mk
-	$(mkinstalldirs) $(DESTDIR)$(plugin_includedir)
-	$(INSTALL_DATA) $< $(DESTDIR)/$(plugin_includedir)/
+	$(mkinstalldirs) $(DESTDIR)$(libexecsubdir)
+	$(INSTALL_DATA) $< $(DESTDIR)/$(libexecsubdir)/
 
 ## install the default modules list
 install-melt-default-modules-list: $(melt_default_modules_list).modlis 

Re: [PATCH, MELT] correcting path error in the Makefile.in

[Basile Starynkevitch]

On Tue, 17 May 2011 21:30:44 +0200
Pierre Vittet <piervit@pvittet.com> wrote:

> This patch correct a bug in the current revision of MELT, which was 
> preventing MELT to run correctly.
> 
> This was a path problem in gcc/Makefile.in (melt-modules/ and 
> melt-modules.mk) were not found.
> 
> My contributor number is 634276.
> 
> changelog :
> 
> 
> 2011-05-17  Pierre Vittet  <piervit@pvittet.com>
> 
> 	* Makefile.in : Correct path errors for melt_module_dir and for
> 	install-melt-mk target

The ChangeLog.MELT entry should mention the Makefile target as
changelog functions. And the colon shouldn't have any space before.
So I applied the patch with the following entry:

2011-05-17  Pierre Vittet  <piervit@pvittet.com>

	* Makefile.in (melt_module_dir,install-melt-mk): Correct path
	errors.
Committed revision 173835.

Thanks.


-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mine, sont seulement les miennes} ***

Re: [PATCH, MELT] correcting path error in the Makefile.in

[Basile Starynkevitch]

On Wed, May 18, 2011 at 10:27:11AM +0400, Andrey Belevantsev wrote:

> On 17.05.2011 23:42, Basile Starynkevitch wrote:
> >On Tue, 17 May 2011 21:30:44 +0200
> >Pierre Vittet<piervit@pvittet.com>  wrote:
> 
> >>My contributor number is 634276.
> You don't have to write your FSF contributor number in each mail to
> gcc-patches.  This information is irrelevant to anybody reading the
> list as soon as you have got your papers right and got acquainted
> with the community.  So don't worry about this :)


It would help a lot if Pierre Vittet had a write access to the SVN of GCC.
Hese legal papers are done. However, neither Pierre nor me understands how
can he get an actual write access to the SVN (that is an SSH account on
gcc.gnu.org). Apparently, Pierre needs to be presented (or introduced) by someone. But a plain write after approval GCC maintainer like me is not enough.

So how can Pierre get write access to GCC ?

Regards.


PS. I am Pierre GSOC's mentor and I advised him to put his number on every
patch he is sending until he got a write access, so please blame me Basile,
not him Pierre.

-- 
Basile STARYNKEVITCH         http://starynkevitch.net/Basile/
email: basile<at>starynkevitch<dot>net mobile: +33 6 8501 2359
8, rue de la Faiencerie, 92340 Bourg La Reine, France
*** opinions {are only mines, sont seulement les miennes} ***

Re: [PATCH, MELT] correcting path error in the Makefile.in

[Ian Lance Taylor]

Basile Starynkevitch <basile@starynkevitch.net> writes:

> On Wed, May 18, 2011 at 10:27:11AM +0400, Andrey Belevantsev wrote:
>
>> On 17.05.2011 23:42, Basile Starynkevitch wrote:
>> >On Tue, 17 May 2011 21:30:44 +0200
>> >Pierre Vittet<piervit@pvittet.com>  wrote:
>> 
>> >>My contributor number is 634276.
>> You don't have to write your FSF contributor number in each mail to
>> gcc-patches.  This information is irrelevant to anybody reading the
>> list as soon as you have got your papers right and got acquainted
>> with the community.  So don't worry about this :)
>
>
> It would help a lot if Pierre Vittet had a write access to the SVN of GCC.
> Hese legal papers are done. However, neither Pierre nor me understands how
> can he get an actual write access to the SVN (that is an SSH account on
> gcc.gnu.org). Apparently, Pierre needs to be presented (or introduced) by someone. But a plain write after approval GCC maintainer like me is not enough.
>
> So how can Pierre get write access to GCC ?

We usually like to see a few successful patches before granting people
write access, to make sure that people have the mechanics down before
they start changing the repository.

Ian