From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7246 invoked by alias); 22 Oct 2009 03:53:05 -0000 Received: (qmail 7236 invoked by uid 22791); 22 Oct 2009 03:53:05 -0000 X-SWARE-Spam-Status: No, hits=-2.6 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.45.13) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 22 Oct 2009 03:53:00 +0000 Received: from wpaz24.hot.corp.google.com (wpaz24.hot.corp.google.com [172.24.198.88]) by smtp-out.google.com with ESMTP id n9M3qwOq031305 for ; Wed, 21 Oct 2009 20:52:59 -0700 Received: from fxm7 (fxm7.prod.google.com [10.184.13.7]) by wpaz24.hot.corp.google.com with ESMTP id n9M3qtld009894 for ; Wed, 21 Oct 2009 20:52:55 -0700 Received: by fxm7 with SMTP id 7so8175033fxm.34 for ; Wed, 21 Oct 2009 20:52:55 -0700 (PDT) Received: by 10.204.10.136 with SMTP id p8mr8022161bkp.56.1256183574851; Wed, 21 Oct 2009 20:52:54 -0700 (PDT) Received: from coign.google.com (adsl-71-133-8-30.dsl.pltn13.pacbell.net [71.133.8.30]) by mx.google.com with ESMTPS id 1sm1353039fkt.41.2009.10.21.20.52.52 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 21 Oct 2009 20:52:53 -0700 (PDT) To: Carrot Wei Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH: PR target/41705] Enable if conversion for thumb1 by new HAVE_conditional_execution definition References: <7587b290910160620l1266a752n651300451b392e64@mail.gmail.com> <7587b290910162232se0c399eqe0a39b9832c70be4@mail.gmail.com> <7587b290910190728s7e4841e4n2a40d9844411a913@mail.gmail.com> From: Ian Lance Taylor Date: Thu, 22 Oct 2009 05:29:00 -0000 In-Reply-To: <7587b290910190728s7e4841e4n2a40d9844411a913@mail.gmail.com> (Carrot Wei's message of "Mon\, 19 Oct 2009 22\:28\:28 +0800") Message-ID: User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2009-10/txt/msg01397.txt.bz2 Carrot Wei writes: > +bool default_have_conditional_execution (void) > +{ Line break after "bool". > +/* Only thumb1 can't support conditional execution, so return true if > + the target is not thumb1. */ > +bool > +arm_have_conditional_execution (void) > +{ > + return !TARGET_THUMB1; > +} > + Make this function static. Add a static declaration at the top of the file near the other static declarations. Define is higher in the file, perhaps around the cost functions. > Index: config/arm/arm-protos.h > =================================================================== > --- config/arm/arm-protos.h (revision 152888) > +++ config/arm/arm-protos.h (working copy) > @@ -41,7 +41,8 @@ extern HOST_WIDE_INT thumb_compute_initi > unsigned int); > extern unsigned int arm_dbx_register_number (unsigned int); > extern void arm_output_fn_unwind (FILE *, bool); > - > +extern bool arm_have_conditional_execution (void); Do not declare this here. > @@ -146,7 +147,8 @@ extern const char *vfp_output_fstmd (rtx > extern void arm_set_return_address (rtx, rtx); > extern int arm_eliminable_register (rtx); > extern const char *arm_output_shift(rtx *, int); > - > +extern bool removable_cmp_0 (rtx cmp_op); > +extern const char *emit_branch_after_movs (rtx *operands); > extern bool arm_output_addr_const_extra (FILE *, rtx); This seems like an unrelated change which should not be in this patch. Please send a new patch. Please also test the new patch on x86 or x86_64 GNU/Linux. I would like to hear if the ARM maintainers have any comments. Thanks. Ian