From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27713 invoked by alias); 21 Apr 2011 23:39:59 -0000 Received: (qmail 27705 invoked by uid 22791); 21 Apr 2011 23:39:59 -0000 X-SWARE-Spam-Status: No, hits=-2.3 required=5.0 tests=AWL,BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,SPF_HELO_PASS,T_RP_MATCHES_RCVD,T_TVD_MIME_NO_HEADERS X-Spam-Check-By: sourceware.org Received: from smtp-out.google.com (HELO smtp-out.google.com) (216.239.44.51) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Thu, 21 Apr 2011 23:39:44 +0000 Received: from wpaz33.hot.corp.google.com (wpaz33.hot.corp.google.com [172.24.198.97]) by smtp-out.google.com with ESMTP id p3LNdh0j019123 for ; Thu, 21 Apr 2011 16:39:43 -0700 Received: from pwj9 (pwj9.prod.google.com [10.241.219.73]) by wpaz33.hot.corp.google.com with ESMTP id p3LNdfbm015893 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=NOT) for ; Thu, 21 Apr 2011 16:39:42 -0700 Received: by pwj9 with SMTP id 9so158990pwj.34 for ; Thu, 21 Apr 2011 16:39:41 -0700 (PDT) Received: by 10.142.52.6 with SMTP id z6mr261817wfz.313.1303429181019; Thu, 21 Apr 2011 16:39:41 -0700 (PDT) Received: from coign.google.com ([216.239.45.130]) by mx.google.com with ESMTPS id w14sm2275224wfh.8.2011.04.21.16.39.39 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 21 Apr 2011 16:39:40 -0700 (PDT) From: Ian Lance Taylor To: Rainer Orth Cc: Uros Bizjak , gcc-patches@gcc.gnu.org, gofrontend-dev@googlegroups.com Subject: Re: [RFC PATCH, go]: Port to ALPHA arch - sysinfo.go fixup References: Date: Fri, 22 Apr 2011 01:31:00 -0000 In-Reply-To: (Rainer Orth's message of "Thu, 07 Apr 2011 21:15:47 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-System-Of-Record: true X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2011-04/txt/msg01836.txt.bz2 --=-=-= Content-length: 1021 Rainer Orth writes: > Here's the error I run into: > > /vol/gcc/src/hg/trunk/irix/libgo/go/os/file.go:432:12: error: incompatible types in assignment (implicit assignment of 'syscall.Timeval' hidden field '_f0') > /vol/gcc/src/hg/trunk/irix/libgo/go/os/file.go:433:12: error: incompatible types in assignment (implicit assignment of 'syscall.Timeval' hidden field '_f0') > /vol/gcc/src/hg/trunk/irix/libgo/go/os/file.go:434:37: error: argument 2 has incompatible type (implicit assignment of 'syscall.Timeval' hidden field '_f0') > make[8]: *** [os/os.lo] Error 1 > >> What does the line for timeval look like in gen-sysinfo.go? > > I get > > type Timeval struct { _f0 int32; Sec Timeval_sec_t; Usec Timeval_usec_t; } Thanks. I fixed this problem with this patch. Bootstrapped and ran Go testsuite on x86_64-unknown-linux-gnu. Committed to mainline. Ian 2011-04-21 Ian Lance Taylor * godump.c (go_format_type): Use exported Go name for anonymous field name. --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=foo.patch Content-Description: patch Content-length: 402 Index: gcc/godump.c =================================================================== --- gcc/godump.c (revision 172331) +++ gcc/godump.c (working copy) @@ -675,7 +675,7 @@ go_format_type (struct godump_container { char buf[100]; - obstack_grow (ob, "_f", 2); + obstack_grow (ob, "Godump_", 2); snprintf (buf, sizeof buf, "%d", i); obstack_grow (ob, buf, strlen (buf)); i++; --=-=-=--