* Go patch committed: Don't finalize methods more than once
@ 2010-12-21 22:53 Ian Lance Taylor
0 siblings, 0 replies; only message in thread
From: Ian Lance Taylor @ 2010-12-21 22:53 UTC (permalink / raw)
To: gcc-patches, gofrontend-dev
[-- Attachment #1: Type: text/plain, Size: 258 bytes --]
This patch to the Go frontend prevents the compiler from trying to
finalize the methods for a type more than once. This avoids an endless
loop in an invalid case. Bootstrapped and ran Go testsuite on
x86_64-unknown-linux-gnu. Committed to mainline.
Ian
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: methods --]
[-- Type: text/x-diff, Size: 574 bytes --]
diff -r 7975dbfdedb1 go/types.cc
--- a/go/types.cc Tue Dec 21 13:12:12 2010 -0800
+++ b/go/types.cc Tue Dec 21 14:29:10 2010 -0800
@@ -3698,6 +3698,8 @@
void
Struct_type::finalize_methods(Gogo* gogo)
{
+ if (this->all_methods_ != NULL)
+ return;
Type::finalize_methods(gogo, this, this->location_, &this->all_methods_);
}
@@ -6615,6 +6617,9 @@
void
Named_type::finalize_methods(Gogo* gogo)
{
+ if (this->all_methods_ != NULL)
+ return;
+
if (this->local_methods_ != NULL
&& (this->points_to() != NULL || this->interface_type() != NULL))
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2010-12-21 22:33 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-12-21 22:53 Go patch committed: Don't finalize methods more than once Ian Lance Taylor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).