From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x430.google.com (mail-pf1-x430.google.com [IPv6:2607:f8b0:4864:20::430]) by sourceware.org (Postfix) with ESMTPS id 3978E3857006 for ; Wed, 17 May 2023 02:13:46 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3978E3857006 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x430.google.com with SMTP id d2e1a72fcca58-643bb9cdd6eso182112b3a.1 for ; Tue, 16 May 2023 19:13:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1684289625; x=1686881625; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=8jpYlI99S2HSDRH5KyvQL9Yy5a7bSuuLHT6he1XyEHA=; b=u7KZzdJIXHSUbPu8AOj+HLEiuqRYdW/sUhNb2J68NbbfUUWc5s5oAI3Bd0MP0PKcJn ry+ltjIsvHAo+Nc6kNQ0JTEvY0oFYBBZPrVZePKhxf/JjbHnIrVuVLyY8LFzfqjgSyT6 fEMfnOu3mBiEiEaqXSb8E2ec0FWLgXUBDGtwe5q/UJurqW8q8TmcWQGjJrEqbAL45whf tW8khRoneGa7l65waRApXTHR32IzAltqTczcvaATtVDFNhW5te1bDZEY6TVRuxaT6fJH u3ITU23v+pXTYWy5fwyiZq7zwEKSvRBMd4tm4Y/9V6tDNXD7bXYbyxrS7vxj5rN0ZB1X 1pSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684289625; x=1686881625; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8jpYlI99S2HSDRH5KyvQL9Yy5a7bSuuLHT6he1XyEHA=; b=gdQ7ZCmzmq1Z6ucRsBWqicFW4JnTAdImI8YE0xHTxbGYptyxNBbGDpSw5BdyXWSJo+ 1D3s8F8JvwPF5FJHYeVa+eTh6DxKouCrbkS/RmE2xOSiH/6qukKNK0C0hHLIMn7fjoWP KWqfZcYRrh4En+P7Kq0fX0BXrkXOFGCePB3i/TUicRrR+S32oqb0RJeCEs5y10L36k5h VWmHxRX1KqHXd9GDgmkNjfR7bI+WlX+Oq/zIaooyMP8qa3/z8t5k4JKtUWwzdI7y8lqk MWaZFfUsdSO3mjFojanPotvJuG9ao+0/cylL0yN3lpaoI8/iYE92QrT/26cjyDpOgSJZ CcoA== X-Gm-Message-State: AC+VfDzS0Qj9zCixPtE0AfZgZxv/u+fRnWApX88Zj5J8k/JgYLnWeTeU mQM8mbZqf0q/GVHlBgXQaCvEZA== X-Google-Smtp-Source: ACHHUZ4gRTV20bpEJ5vWtPROIQSam+rPNAc45p1X/alVFrUGcMm6P7dbho6PjLbEa4/HaD7SikScRQ== X-Received: by 2002:a05:6a21:99a1:b0:105:eded:5369 with SMTP id ve33-20020a056a2199a100b00105eded5369mr12671082pzb.53.1684289625154; Tue, 16 May 2023 19:13:45 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id 17-20020a170902c11100b001aad714400asm16177996pli.229.2023.05.16.19.13.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 16 May 2023 19:13:44 -0700 (PDT) Date: Tue, 16 May 2023 19:13:44 -0700 (PDT) X-Google-Original-Date: Tue, 16 May 2023 19:13:13 PDT (-0700) Subject: Re: Re: RISC-V Test Errors and Failures In-Reply-To: CC: pinskia@gmail.com, gcc-patches@gcc.gnu.org, Kito.cheng@sifive.com From: Palmer Dabbelt To: juzhe.zhong@rivai.ai Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 16 May 2023 19:07:01 PDT (-0700), juzhe.zhong@rivai.ai wrote: > Oh, I see. Kito has add /* { dg-do run { target { riscv_vector } } } */ > But not all RVV tests has use this and I not sure whether it can work. > I think Kito can answer it. > If yes, I think we should add all of them. Unless I'm missing something, it looks like that only checks if GCC is compiling for V. Nothing appears to be checking if the system the tests are running on supports V. # Return 1 if the target has RISC-V vector extension, 0 otherwise. # Cache the result. proc check_effective_target_riscv_vector { } { # Check that we are compiling for v by checking the __riscv_v marco. return [check_no_compiler_messages riscv_vector assembly { #if !defined(__riscv_v) #error "__riscv_v not defined!" #endif }] } Those are really just two different things. It seems pretty reasonably to me to just avoid running the tests when the DUT lacks V, but I'm never great with DG. We should probably add similar checks for the other ISA extensions, there's going to be a bunch of this. > > Thanks. > > > juzhe.zhong@rivai.ai > > From: Andrew Pinski > Date: 2023-05-17 10:02 > To: juzhe.zhong@rivai.ai > CC: gcc-patches; palmer; Kito.cheng > Subject: Re: RISC-V Test Errors and Failures > On Tue, May 16, 2023 at 6:58 PM juzhe.zhong@rivai.ai > wrote: >> >> Hi, Palmer. >> I saw your patch showed there are a lot of run time fail (execution fail) of C++. >> bug-*.C >> >> These tests are RVV api intrinsics tests coming from Kito's that I have already fixed all of them. >> I just double checked again they all passed. >> I think it may be your regression environment does not set up simulator (QEMU or SPIKE or GEM5) correctly. >> For example, did not enable vector extension in simulator, I don't you may try. > > So on x86_64, we test to see if you have the right vector unit before > running those tests? The same thing was true on powerpc (and I think > aarch64 does the same for SVE now too). The reason why I am asking is > that I would need to run the testsuite using the simulator as setup > for the RISCV ISA I am using rather than the one with everything on. > So does the RVV runtime testsuite tests to see if you can run RVV > before running them (or running them and return they passed)? > > Thanks, > Andrew Pinski > >> >> Thanks. >> >> >> juzhe.zhong@rivai.ai >