From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by sourceware.org (Postfix) with ESMTPS id 949DA3858CD1 for ; Wed, 3 Apr 2024 03:43:29 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 949DA3858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 949DA3858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::636 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712115811; cv=none; b=fUhU04ddTUX3ZbFZFm0n5DnzHcusLuUytR7gyqkDN7/zg1CHbnGOLc7nqnl2TNWJKpBkekchvongqd3AkLjbdQkajwm8K+rFSaLk4ADoHXD/uMXKgd8LKOpucus0VAXBLfbgl3CDKtDEPewL0r2pgE8lrTEUzzGa8LOrKiTilUY= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1712115811; c=relaxed/simple; bh=BKOMCcS2RtDbwHXB6aqCadns+c0EOD3yJ27y2QxHcQQ=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=o6RM5lk/zC16tEvAKwILbKw++zTXMc1AmtV7G9EJC0Xdcu1lOFLRyQpTtp6x9o5ScZXAeGWOH8nmt1yluHU+olQfaNZZO1kr8wwIokp77OB0MlmZQyYGTgd4A+PEeOgWRdJ4iG+3ym6I1FAqJwbpg1J1mm2O/86bEjg70Vmy3TU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pl1-x636.google.com with SMTP id d9443c01a7336-1e0d8403257so45991995ad.1 for ; Tue, 02 Apr 2024 20:43:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1712115807; x=1712720607; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=I0isdZLlLGI2CmuYKW8+f6KTf4nLBr/HBL/1kAmQ3xg=; b=xe5fm2OiXp5KvY4SLuRPuU/TyOVOZPJtDzcY3po1BFdFDysF7Ujd0B0oG9Eh/zPTF7 a8oSLpuGX5C875XZGL3j4v746dA3NfHhJMYNQYXbITswAhPUIbeTs0vMxvvrN2hikG1V hgqfF0Zs2OT6KKxOT4laNnHdpCndq8ee2ANWETXXP94h/Mr87eMn7MrKsR0urilDIW4T oMPOAs2DjLTBoWTdtKQ2Y8GrXeH48bnbLH8UXQV3h7iLc4BvwF2BnK7WCDzptXWhA7YE j+I1W5hI56VAKjSF1zNG8J0xn7pI8UErsziaqJcMyHZFDhiad+7LN7gXCozU5qLPIVvG L4kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1712115807; x=1712720607; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=I0isdZLlLGI2CmuYKW8+f6KTf4nLBr/HBL/1kAmQ3xg=; b=h1weg88ZBw5FWnhcuwCTMXZH7rAebSaUjHfLxxFLThSDtlKTwRQ+WXRJDIsZFWHldw wT7i1wgLFX4/Xt1+q5g5lVjQ4dLKcyF9HfVUFYYmWtHGSXk3pAsapnRVjOm6xd8dA9O4 VAJn6BS/pXNOWiPaESqqiBI06cmwt+FaWgi3a3PDok3dRyEq5fYtixDDkZs1r9BsMzDy ukjLe6HOWXQmFeoi+wTIoy5nsw/MA0vzSsFU49Bh4G9OyEze0CT7J7+VKt2Om5BX7Dd+ 5bzmm/T32g/oPa1TFb6I40CmoPyU+9KEAtmrszxesvyTsSxYATLWmWhRbIvrej2rlKsa 8ojQ== X-Forwarded-Encrypted: i=1; AJvYcCWSu4kAxdLH/6e2lBlZr80QC003p+zv5EaYS7fPWzmCbCZT4Qmhzd7H2og2zQyvdGxLx1jAjNnRyJXHKb+OBdGPmN6/yneQag== X-Gm-Message-State: AOJu0YxI3l1FLxBSM8VHsptoqJi1a07VnhNxAl+X7UVsxvPR1Nl827Ai ySwZd0kGwNS0enMdikyBMIr+AyoDnnF57GNJY0R2Odb+R/i3KvhWKH4zwiqxQ6s= X-Google-Smtp-Source: AGHT+IHjbBsyWRmwcOceqt6SIKoOEbMc7sZr82W7tiynL3DWlmlBn6lBRXc+KMyMunTrd60407wrYg== X-Received: by 2002:a17:903:32c9:b0:1e0:2a42:56a4 with SMTP id i9-20020a17090332c900b001e02a4256a4mr16546058plr.4.1712115807374; Tue, 02 Apr 2024 20:43:27 -0700 (PDT) Received: from localhost ([192.184.165.199]) by smtp.gmail.com with ESMTPSA id i10-20020a17090332ca00b001e0f504a74csm11972270plr.269.2024.04.02.20.43.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Apr 2024 20:43:26 -0700 (PDT) Date: Tue, 02 Apr 2024 20:43:26 -0700 (PDT) X-Google-Original-Date: Tue, 02 Apr 2024 20:43:25 PDT (-0700) Subject: Re:[PATCH v2 1/1] [RISC-V] Add support for _Bfloat16 In-Reply-To: CC: zengxiao@eswincomputing.com, gcc-patches@gcc.gnu.org, jeffreyalaw@gmail.com, research_trasio@irq.a4lg.com, Kito Cheng , zhengyu@eswincomputing.com From: Palmer Dabbelt To: jinma@linux.alibaba.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-3.6 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,KAM_NUMSUBJECT,KAM_SHORT,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 02 Apr 2024 20:19:16 PDT (-0700), jinma@linux.alibaba.com wrote: >> gcc/testsuite/ChangeLog: >> >> * gcc.target/riscv/bf16_arithmetic.c: New test. >> * gcc.target/riscv/bf16_call.c: New test. >> * gcc.target/riscv/bf16_comparison.c: New test. >> * gcc.target/riscv/bf16_float_libcall_convert.c: New test. >> * gcc.target/riscv/bf16_integer_libcall_convert.c: New test. > > Hi, I have test this patch and it is very good. I think we need to add some > runable tests to ensure that the results are right for various types of > conversions, operations, and libfuncs. Sorry I forgot to reply earlier, a few of us were talking about this is the patchwork meeting this morning. We think this is too big for GCC-14 this late in the cycle. Folks are still looking at bugs, so it might take a bit to get reviewed for GCC-15. I took a look and don't see anything wrong, but I'm not a floating-point person so I'd want to try and talk to someone who is before committing it. More testing never hurts, though ;) > > BR, > Jin