From: Palmer Dabbelt <palmer@rivosinc.com>
To: gcc-patches@gcc.gnu.org
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] RISC-V: Set the ABI for the RVV tests
Date: Mon, 17 Apr 2023 12:19:54 -0700 (PDT) [thread overview]
Message-ID: <mhng-1cdabb63-29e8-445d-b999-8d1df88651ac@palmer-ri-x1c9a> (raw)
In-Reply-To: <CA+yXCZCSV9fd0dh1fPQwwuSUdnptWT_cuBUgz0d=hzZqX=4jyw@mail.gmail.com>
On Thu, 13 Apr 2023 08:59:58 PDT (-0700), gcc-patches@gcc.gnu.org wrote:
> Ok, thanks :)
Committed.
>
> Palmer Dabbelt <palmer@rivosinc.com>於 2023年4月13日 週四,23:12寫道:
>
>> The RVV test harness currently sets the ISA according to the target
>> tuple, but doesn't also set the ABI. This just sets the ABI to match
>> the ISA, though we should really also be respecting the user's specific
>> ISA to test.
>>
>> gcc/testsuite/ChangeLog:
>>
>> * gcc.target/riscv/rvv/rvv.exp (gcc_mabi): New variable.
>> ---
>> I've still got some rv32-related multilib failures so there might be
>> something else going on here, but I think at least this is going to be
>> necessary.
>> ---
>> gcc/testsuite/gcc.target/riscv/rvv/rvv.exp | 4 +++-
>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> index 7a9a2b6ac48..4b5509db385 100644
>> --- a/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> +++ b/gcc/testsuite/gcc.target/riscv/rvv/rvv.exp
>> @@ -31,15 +31,17 @@ if ![info exists DEFAULT_CFLAGS] then {
>> }
>>
>> set gcc_march "rv64gcv_zfh"
>> +set gcc_mabi "lp64d"
>> if [istarget riscv32-*-*] then {
>> set gcc_march "rv32gcv_zfh"
>> + set gcc_mabi "ilp32d"
>> }
>>
>> # Initialize `dg'.
>> dg-init
>>
>> # Main loop.
>> -set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -O3"
>> +set CFLAGS "$DEFAULT_CFLAGS -march=$gcc_march -mabi=$gcc_mabi -O3"
>> dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/base/*.\[cS\]]] \
>> "" $CFLAGS
>> gcc-dg-runtest [lsort [glob -nocomplain $srcdir/$subdir/vsetvl/*.\[cS\]]]
>> \
>> --
>> 2.39.2
>>
>>
prev parent reply other threads:[~2023-04-17 19:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-13 15:10 Palmer Dabbelt
2023-04-13 15:59 ` Kito Cheng
2023-04-17 19:19 ` Palmer Dabbelt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=mhng-1cdabb63-29e8-445d-b999-8d1df88651ac@palmer-ri-x1c9a \
--to=palmer@rivosinc.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).