public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@dabbelt.com>
To: jeffreyalaw@gmail.com
Cc: best124612@gmail.com, gcc-patches@gcc.gnu.org,
	Kito Cheng <kito.cheng@gmail.com>
Subject: Re: [RFC][V2] RISC-V: Support -mcmodel=large.
Date: Wed, 20 Dec 2023 10:05:48 -0800 (PST)	[thread overview]
Message-ID: <mhng-2208294a-a60e-4331-b16a-3e1ac0838518@palmer-ri-x1c9a> (raw)
In-Reply-To: <c77fe968-827f-47cd-9d4f-755c2c1a34ff@gmail.com>

On Wed, 20 Dec 2023 09:55:48 PST (-0800), jeffreyalaw@gmail.com wrote:
>
>
> On 12/18/23 00:46, KuanLin Chen wrote:
>> Hi Jeff,
>>
>> Sorry for this missing.
>> I've removed riscv_asm_output_pool_epilogue because the pool
>> beginning is always aligned from FUNCTION_BOUNDARY.
>> Please find attached. Thank you.
> Thanks. I regression tested this on rv64gc without any issues and fixed
> up the ChangeLog a bit.  Pushed to the trunk.  Thanks for your patience.

Looks like the psABI PR is still open 
<https://github.com/riscv-non-isa/riscv-elf-psabi-doc/pull/388>?

I guess there's no hard psABI dependency here, we're just doing constant 
pools so there's no new assembler/linker stuff that's strictly 
necessary.  I'm fine just ignoring the psABI as it's a pretty miserable 
place to try and get things done, we're started doing that where we can 
elsewhere as well.

So maybe we should just close that PR?

> jeff

  reply	other threads:[~2023-12-20 18:05 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-10  9:00 KuanLin Chen
2023-11-10  9:10 ` KuanLin Chen
2023-12-17 19:15   ` Jeff Law
2023-12-18  7:46     ` KuanLin Chen
2023-12-20 17:55       ` Jeff Law
2023-12-20 18:05         ` Palmer Dabbelt [this message]
2023-12-20 18:12           ` Jeff Law
2023-12-20 18:21             ` Palmer Dabbelt
2023-12-20 18:25               ` Jeff Law
2023-12-20 18:41                 ` Palmer Dabbelt
2023-12-20 21:13                   ` Patrick O'Neill

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=mhng-2208294a-a60e-4331-b16a-3e1ac0838518@palmer-ri-x1c9a \
    --to=palmer@dabbelt.com \
    --cc=best124612@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jeffreyalaw@gmail.com \
    --cc=kito.cheng@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).