From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pf1-x436.google.com (mail-pf1-x436.google.com [IPv6:2607:f8b0:4864:20::436]) by sourceware.org (Postfix) with ESMTPS id 75C153858D35 for ; Thu, 17 Aug 2023 17:51:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 75C153858D35 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=rivosinc.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=rivosinc.com Received: by mail-pf1-x436.google.com with SMTP id d2e1a72fcca58-6887ccba675so40012b3a.3 for ; Thu, 17 Aug 2023 10:51:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20221208.gappssmtp.com; s=20221208; t=1692294695; x=1692899495; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=GSCAOiz2pomLfTRXclrJJyu0dmHyeNnqSJRfTE+FFuY=; b=rJg7xZtBuVJaeXfQN3fai7WqRZHVV9qR2KyFydKEdE2Tzk5YERzp1eOn4mNLwmriIL QktDtmWDKmq3SBXoF09fVGzbrWmBuZvPxJ5cgbWWzQNm6atHLiFPFyxwQvoc1JlQ891p J1Vhe5ivYAcqpV29nNFu8hlCYwwsIagXmj7jInlZJqFUbZIYLZjOtTJ+pQAB3FBgym0p S8tb7KjVOkNaQJF6r+OdIvRBWSRaC/GdcMrvh+aeyFo7S/kgcNalBZdnO12q/aTlmzEL YjEw491eFiNwlBAIK1pTVUUbFnY6Pnt4HPoihYkSvULm4vx+fiBp+ncZrORxqtQfSlDH C24A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692294695; x=1692899495; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=GSCAOiz2pomLfTRXclrJJyu0dmHyeNnqSJRfTE+FFuY=; b=asUW4T1ibmE5h6fi25egxwcAKo2gVg2u4vgL7QAQmUdO/+umQ2HghFnGden91Xgz9n b89LSxmGfKuBRQroqfzOF3iy/sw4ZhWi9fam3B+feFMpUXDkd1mkxSyOD0mrxLmhl8XK Ag3uqrJuvwgtiRiPpdEt1QhyTAyiPxjOr69KV4d05EXIz9AH76RfTocC6pACJrfuc1fQ nsLdR7YTqkZQK/ljaREpKjOhYzVIPMVYfkgXBn+pAFmXRbkC6RzVSlwOG6gkvl8bCBMx +YqqOK2i1Y3Qy+HrE9oHKvrygb+QkXkuVknNPbZljy3GqZv5KBVtC0H3YYqH2iZzBSEj Psnw== X-Gm-Message-State: AOJu0YzGE3zNAHfIRl7pI38B1ctnzOIL8McZ8Pb7S7aQmdpfBbB/BwWA f3qS+s68c6ykHzlbAZvXeYgZeg== X-Google-Smtp-Source: AGHT+IHvC2En8ATojNVc8hEdJQcD3XBbzbWjYKdApmi1UoNn4o3D3NF7dMqWU7nvUw63x6X/v4s3Vg== X-Received: by 2002:a05:6a00:1803:b0:67f:48a2:5d9f with SMTP id y3-20020a056a00180300b0067f48a25d9fmr295771pfa.11.1692294695288; Thu, 17 Aug 2023 10:51:35 -0700 (PDT) Received: from localhost ([50.221.140.188]) by smtp.gmail.com with ESMTPSA id x52-20020a056a000bf400b006870ff20254sm42541pfu.125.2023.08.17.10.51.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 17 Aug 2023 10:51:34 -0700 (PDT) Date: Thu, 17 Aug 2023 10:51:34 -0700 (PDT) X-Google-Original-Date: Thu, 17 Aug 2023 10:51:33 PDT (-0700) Subject: Re: [PATCH V2] RISC-V: Add the missed half floating-point mode patterns of local_pic_load/store when only use zfhmin or zhinxmin In-Reply-To: <896ba850-35c0-70b9-0dfd-ddc6d061b496@gmail.com> CC: lehua.ding@rivai.ai, gcc-patches@gcc.gnu.org, rdapp.gcc@gmail.com, juzhe.zhong@rivai.ai, Kito Cheng , jeffreyalaw@gmail.com From: Palmer Dabbelt To: rdapp.gcc@gmail.com Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Thu, 17 Aug 2023 10:03:04 PDT (-0700), rdapp.gcc@gmail.com wrote: > Indeed all ANYLSF patterns have TARGET_HARD_FLOAT (==f extension) which > is incompatible with ZHINX or ZHINXMIN anyway. That should really be fixed > separately or at least clarified, maybe I'm missing something. We've also got the broader issue where these PIC patterns are likely not the way to go long term, they're just papering around some other issues (and are likely why we flip the implicit-relocs behavior implicitly). We should probably fix that at some point, but I don't see any reason to block a fix on a cleanup. That said, given that folks are poking around in here it's probably worth putting together test cases for the other patterns in there. > Still we can go forward with the patch itself as it improves things > independently, so LGTM. Ya, IMO it's fine to add these given they fix the issue. > Regards > Robin