From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg1-x536.google.com (mail-pg1-x536.google.com [IPv6:2607:f8b0:4864:20::536]) by sourceware.org (Postfix) with ESMTPS id 3C6723858CD1 for ; Wed, 20 Dec 2023 18:21:42 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3C6723858CD1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=dabbelt.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=dabbelt.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 3C6723858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::536 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703096503; cv=none; b=UbJgn/rUXL7UeKV+nyoVHYzd8FyOKqTzS78ppkI7A30umeNUWTbIfxgIJhFr7jq/Ul718jYp5hRlFYfxGYOttksu2j3a8+70bfskgtkfPR+HST2UGRpaXluLfKElXEK+xPUlvKbeYfPuK8GDKnzTWJb/JnWSlkV9QZugAXVdJkE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703096503; c=relaxed/simple; bh=WjI3yyqiXyXbCdQH6WizTHwgmHXcG4vBWIHiuk5f0Ag=; h=DKIM-Signature:Date:Subject:From:To:Message-ID:Mime-Version; b=C3m5XyfWTQwEmpY40rQkbCqoED0cYF4s/f4WgNP2nyJvdlbEOUFDoKJKXTWnZGtvOAQbiYNe06j1gQlpGRJeEf8NI+aaXLjL0yg+y5xF9QfTK5qeNC4DQ+ZCalhZ0mBuzBQTUl0C7CAS9ylCHabYSZQWL9seAsIUw5ZRUnreD5w= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-pg1-x536.google.com with SMTP id 41be03b00d2f7-5c6839373f8so795204a12.0 for ; Wed, 20 Dec 2023 10:21:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=dabbelt-com.20230601.gappssmtp.com; s=20230601; t=1703096501; x=1703701301; darn=gcc.gnu.org; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:from:to:cc:subject:date:message-id :reply-to; bh=kPhI2J/z0eCi6sBU+sUcprghc7JVkPEW2ejPEO4HP7k=; b=nYLGHgYmptdDzsYoCPG+kuPUQWz/yAq5EiHZxpZyufmz+Hd5MrjAAYnbaXhF7X1x4z lk0qVd0TvklQGxeeTQWOcCks+gI5dJybeG/dph45YwGi2NAhaD3oy4VNe4d2NsbTuc4k +21aSaIqloQdjBBUFkqeZb6LXZfSYth+y9emUN4L6J9T6wDw1OBY948HqSbxULfABxk+ XVn/kaTZPdGqSyaZW4GvRe1QHU3FVnv+oIEvCR9iGiPLUCFB/BdhxrSwtOI9WjeTR/zm cb4Ko1LauTtgfgzil5/ZL2nUORuIGZfWBVl1bDnPQ2EuIUk9nTcXTME0/JyJnZl18eJi GYEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1703096501; x=1703701301; h=content-transfer-encoding:mime-version:message-id:to:from:cc :in-reply-to:subject:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kPhI2J/z0eCi6sBU+sUcprghc7JVkPEW2ejPEO4HP7k=; b=gWwCto7IFPhqXZUmJhk1nfvsDrdrmH1Cx9e2BgXm727itiiHM2T7+lQFzgr7sF2ApX DHrOFXunHFYGEkWP9w1itaR2Ha/1BnuvBWApUtk2QohVov28yBInnoIVg4Rjdxt9unvX nHDp+Qn+eNgjn9QRKbJ99EZvlLmNpg7GUDclCS07uGd9oYGY1hkswoBcbcX24n/z07rS OWaN/NP79v/97Ni5fip3rZ3s7q24xXJMOGLqxrdxz8EG6okHrkpvTTpKOU0+3lcI9lWn uoGPf2sOYvEuWZd6w5fqyE0xzrfA142wyC8vTx/plfMFz0wfCmTf2Ug51kUI+BTNFGNz /OLg== X-Gm-Message-State: AOJu0Yy3pdFJnfONMXluEq4biQQ80GXhT5VtF3SipP+HrUJG/i2vrw3T Xpcw6hLH64k8b8OC/L9c1hrulQ== X-Google-Smtp-Source: AGHT+IEqN0cC0fgnhZlTqZFRnajxlIISQqbnRSILz5eDhq8CZvqbKx5bhMR5+K/TCwSAdZvx4HjWPw== X-Received: by 2002:a05:6a21:3284:b0:194:3af:19ca with SMTP id yt4-20020a056a21328400b0019403af19camr63604pzb.47.1703096501021; Wed, 20 Dec 2023 10:21:41 -0800 (PST) Received: from localhost ([12.44.203.122]) by smtp.gmail.com with ESMTPSA id ka34-20020a056a0093a200b006d94206f846sm69144pfb.174.2023.12.20.10.21.40 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 Dec 2023 10:21:40 -0800 (PST) Date: Wed, 20 Dec 2023 10:21:40 -0800 (PST) X-Google-Original-Date: Wed, 20 Dec 2023 10:21:38 PST (-0800) Subject: Re: [RFC][V2] RISC-V: Support -mcmodel=large. In-Reply-To: <4a2baff0-da1c-49e1-864d-583c6145b8aa@gmail.com> CC: best124612@gmail.com, gcc-patches@gcc.gnu.org, Kito Cheng From: Palmer Dabbelt To: jeffreyalaw@gmail.com, Patrick O'Neill Message-ID: Mime-Version: 1.0 (MHng) Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,GB_TO_NAME_FREEMAIL,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Wed, 20 Dec 2023 10:12:04 PST (-0800), jeffreyalaw@gmail.com wrote: > > > On 12/20/23 11:05, Palmer Dabbelt wrote: >> On Wed, 20 Dec 2023 09:55:48 PST (-0800), jeffreyalaw@gmail.com wrote: >>> >>> >>> On 12/18/23 00:46, KuanLin Chen wrote: >>>> Hi Jeff, >>>> >>>> Sorry for this missing. >>>> I've removed riscv_asm_output_pool_epilogue because the pool >>>> beginning is always aligned from FUNCTION_BOUNDARY. >>>> Please find attached. Thank you. >>> Thanks. I regression tested this on rv64gc without any issues and fixed >>> up the ChangeLog a bit.  Pushed to the trunk.  Thanks for your patience. >> >> Looks like the psABI PR is still open >> ? >> >> I guess there's no hard psABI dependency here, we're just doing constant >> pools so there's no new assembler/linker stuff that's strictly >> necessary.  I'm fine just ignoring the psABI as it's a pretty miserable >> place to try and get things done, we're started doing that where we can >> elsewhere as well. > Yea, the implementation relies largely on just pushing stuff into the > constant pool, so we're largely independent ABI stuff with the likely > exception being relocations. Ya, but I think we'd only need the relocations if we were going to try relaxing stuff. We'd kicked around some ideas there: we could de-duplicate constant pools or inline smaller constants. That's all way to complex to try and get into this upcoming binutils release, though (doubly so with this LEB128 ABI break we're still trying to deal with). So I think we can just punt on all that for a bit. We've got bigger fish to fry. > In theory (and I did not test this), it should be possible to use large > code model codegen in a smaller mode and it should interoperate. I > seriously pondered doing that as an additional test, then figured I had > other higher priority items on my list. IMO we should test that. At least the common case of a medlow libc linked into medany programs should be easy. +Patrick: let's add some configs to the CI for this? >> So maybe we should just close that PR? > I'll let Kito chime in on that. WFM, I try to stay as far away from that as possible ;) > > jeff